Closed Bug 1561717 Opened 5 months ago Closed 5 months ago

Add reftests for contain:size on select elements

Categories

(Core :: Layout: Form Controls, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: dholbert, Assigned: morgan)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review

I'm spinning off this bug to land some reftests that morgan wrote for contain:size on <select> over in bug 1476127, which I've made minor tweaks to and reviewed.

These are taken from morgan's patch in attachment 8993746 [details], with these changes:

Attached patch patchSplinter Review
Assignee: nobody → dholbert
Attachment #9074310 - Attachment is obsolete: true
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4c40aafc15e
Add reftests for 'contain:size' on select elements. r=dholbert
Assignee: dholbert → mreschenberg
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

That WPT PR showed lint errors:

ERROR:lint:css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-001.html: Testcase file must have a link to a spec (MISSING-LINK)
ERROR:lint:css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-002.html: Testcase file must have a link to a spec (MISSING-LINK)
ERROR:lint:css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-001-ref.html: The filename contain-size-select-001-ref is shared by: css/css-contain/reference/contain-size-select-001-ref.html, css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-001-ref.html (CSS-COLLIDING-REF-NAME)
ERROR:lint:css/css-contain/reference/contain-size-select-001-ref.html: The filename contain-size-select-001-ref is shared by: css/css-contain/reference/contain-size-select-001-ref.html, css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-001-ref.html (CSS-COLLIDING-REF-NAME)
INFO:lint:
INFO:lint:There were 4 errors (MISSING-LINK: 2 CSS-COLLIDING-REF-NAME: 2)
INFO:lint:You must fix all errors; for details on how to fix them, see
INFO:lint:https://web-platform-tests.org/writing-tests/lint-tool.html
INFO:lint:
INFO:lint:However, instead of fixing a particular error, it's sometimes
INFO:lint:OK to add a line to the lint.whitelist file in the root of the
INFO:lint:web-platform-tests directory to make the lint tool ignore it.
INFO:lint:
INFO:lint:For example, to make the lint tool ignore all 'CSS-COLLIDING-REF-NAME'
INFO:lint:errors in the css/css-contain/reference/contain-size-select-001-ref.html file,
INFO:lint:you could add the following line to the lint.whitelist file.
INFO:lint:
INFO:lint:CSS-COLLIDING-REF-NAME: css/css-contain/reference/contain-size-select-001-ref.html

Flags: needinfo?(dholbert)

Ah, sorry. I'll push a fix to inbound to address those.

(Edit: s/inbound/phabricator/ -- probably a good idea for dbaron to sanity-check to be sure I'm addressing the issue. Thanks!)

Flags: needinfo?(dholbert)
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8399a5d502b9
part 2: Add "elem" suffix to reftests "contain-size-select-*", to avoid name collisions with other WPT tests, and add spec link. r=dbaron
You need to log in before you can comment on or make changes to this bug.