Closed Bug 1561732 Opened 4 months ago Closed 4 months ago

Remove sincos optimization

Categories

(Core :: JavaScript Engine: JIT, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: iain, Assigned: iain)

Details

Attachments

(2 files)

Since we added it five years ago, this optimization has only ever been enabled on OSX. At the time, it gave us a 5% improvement on one Kraken sub-test, and about 1% on octane-box2d. Those aren't big wins, and don't justify the existence of this code.

I'm going to remove it.

Is this useful for FxR?

Forgot to mention earlier: there are at least two bugs (bug 1534492 and bug 1315956) where we have had to do extra work because of this code.

I have reached out to the FxR team for measurements. Their support for MacOS is currently "still unreleased and quite early stage", so this won't matter at all to them in the short/medium term, but we might as well get more data from them before making a final decision.

Update: turns out that my "still unreleased and quite early stage" quote above was about FxR on the desktop in general, not MacOS. FxR doesn't run at all on MacOS yet, and it's unlikely to do so in either the short or the medium term. ("Apple removed all VR references from their web page I understand.") So FxR doesn't give us a reason to keep this code around either.

I'm pulling the lever.

Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4ec67ebfc94
Remove sincos optimization r=mgaudet

Backed out changeset f4ec67ebfc94 (bug 1561732) for run failures

Backout: https://hg.mozilla.org/integration/autoland/rev/8a9279474147d96daf6cfa7aea7ea273c689255f

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f4ec67ebfc945aa8799d826943d9096d52ddb8b5

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254829949&repo=autoland&lineNumber=647

[vcs 2019-07-04T21:22:27.149Z] updating [===============================> ] 192000/279318 5m26s
[vcs 2019-07-04T21:22:28.212Z] updating [===============================> ] 192200/279318 5m32s
[taskcluster:error] Aborting task...
[vcs 2019-07-04T21:22:28.366Z] updating [===============================> ] 192900/279318 5m21s[taskcluster 2019-07-04T21:22:28.375Z] SUCCESS: The process with PID 4000 (child process of PID 2764) has been terminated.
[taskcluster 2019-07-04T21:22:28.375Z] SUCCESS: The process with PID 3916 (child process of PID 3864) has been terminated.
[taskcluster 2019-07-04T21:22:28.375Z] SUCCESS: The process with PID 2764 (child process of PID 3864) has been terminated.
[taskcluster 2019-07-04T21:22:28.375Z] SUCCESS: The process with PID 3864 (child process of PID 1944) has been terminated.
[taskcluster 2019-07-04T21:22:28.375Z]
[taskcluster 2019-07-04T21:22:28.376Z] === Task Finished ===
[taskcluster 2019-07-04T21:22:28.376Z] Task Duration: 20m0.1396039s
[taskcluster:error] Uploading error artifact public/build/profdata.tar.xz from file build/src/artifacts/profdata.tar.xz with message "Could not read file 'Z:\task_1562268187\build\src\artifacts\profdata.tar.xz'", reason "file-missing-on-worker" and expiry 2020-07-03T20:17:46.796Z
[taskcluster:error] TASK FAILURE during artifact upload: file-missing-on-worker: Could not read file 'Z:\task_1562268187\build\src\artifacts\profdata.tar.xz'
[taskcluster:error] Uploading error artifact public/build/profile-run-1.log from file build/src/artifacts/profile-run-1.log with message "Could not read file 'Z:\task_1562268187\build\src\artifacts\profile-run-1.log'", reason "file-missing-on-worker" and expiry 2020-07-03T20:17:46.796Z
[taskcluster:error] TASK FAILURE during artifact upload: file-missing-on-worker: Could not read file 'Z:\task_1562268187\build\src\artifacts\profile-run-1.log'
[taskcluster:error] Uploading error artifact public/build/profile-run-2.log from file build/src/artifacts/profile-run-2.log with message "Could not read file 'Z:\task_1562268187\build\src\artifacts\profile-run-2.log'", reason "file-missing-on-worker" and expiry 2020-07-03T20:17:46.796Z
[taskcluster:error] TASK FAILURE during artifact upload: file-missing-on-worker: Could not read file 'Z:\task_1562268187\build\src\artifacts\profile-run-2.log'
[taskcluster 2019-07-04T21:22:29.380Z] [mounts] Preserving cache: Moving "Z:\task_1562268187\build" to "Z:\caches\c2-oZ3I-SseHnuK8LDBfvg"
[taskcluster 2019-07-04T21:22:29.746Z] [mounts] Denying task_1562268187 access to 'Z:\caches\c2-oZ3I-SseHnuK8LDBfvg'
[taskcluster 2019-07-04T21:23:26.352Z] Uploading redirect artifact public/logs/live.log to URL https://queue.taskcluster.net/v1/task/MygCF-3GTqWkDL0dXREcZg/runs/0/artifacts/public/logs/live_backing.log with mime type "text/plain; charset=utf-8" and expiry 2020-07-03T20:17:46.796Z
[taskcluster:error] Task aborted - max run time exceeded
[taskcluster:error] file-missing-on-worker: Could not read file 'Z:\task_1562268187\build\src\artifacts\profdata.tar.xz'
[taskcluster:error] file-missing-on-worker: Could not read file 'Z:\task_1562268187\build\src\artifacts\profile-run-1.log'
[taskcluster:error] file-missing-on-worker: Could not read file 'Z:\task_1562268187\build\src\artifacts\profile-run-2.log'

Flags: needinfo?(iireland)

It's very unlikely that these failures have anything to do with my patch. The failures happened on Windows 2012, but the patch removes code that was only enabled on MacOS. Landing again; hopefully the patch will stick this time.

Flags: needinfo?(iireland)
Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06e0a127bc84
Remove sincos optimization r=mgaudet
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

--ion-sincos=[on|off] flags should also be removed from fuzz-flags.txt right?

Flags: needinfo?(iireland)

Yes, --ion-sincos should be removed from fuzzing.

Flags: needinfo?(iireland)
Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4cdf6c1719a1
Remove ion-sincos from fuzz-flags.txt r=gkw
You need to log in before you can comment on or make changes to this bug.