Closed Bug 1561734 Opened 5 months ago Closed 5 months ago

Add trackingAnnotationTable to content blocking problem reports

Categories

(Firefox :: Protections UI, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: arthur, Assigned: ehsan)

Details

Attachments

(1 file)

We would like to know which problem reports from Content Blocking are when the user has the strict-list content blocking enabled. So we will need the trackingAnnotationTable pref included in the reports. Please see: https://searchfox.org/mozilla-central/source/browser/base/content/browser-contentblocking.js#990

That is a static pref, see https://searchfox.org/mozilla-central/rev/0671407b7b9e3ec1ba96676758b33316f26887a4/modules/libpref/init/all.js#5224.

The pref you probably want is privacy.annotate_channels.strict_list.enabled.

Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/b3c13d7442a8
Add privacy.annotate_channels.strict_list.enabled to content blocking problem reports; r=ewright
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Comment on attachment 9075470 [details]
Bug 1561734 - Add privacy.annotate_channels.strict_list.enabled to content blocking problem reports;

Beta/Release Uplift Approval Request

  • User impact if declined: We'd like to uplift this to Beta in order to improve the quality of the content blocking site breakage reports we receive from users, in order to improve the quality of the Enhanced Tracking Protection feature which we hope to enable for all users soon.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It adds a line to the site breakage report that gets sent when the user uses the respective UI, and has an automated test. It otherwise has no impact at all.
  • String changes made/needed: None
Attachment #9075470 - Flags: approval-mozilla-beta?

Comment on attachment 9075470 [details]
Bug 1561734 - Add privacy.annotate_channels.strict_list.enabled to content blocking problem reports;

This was auto-merged to Beta69 already. No need for uplift.
https://hg.mozilla.org/releases/mozilla-beta/rev/b3c13d7442a8

Attachment #9075470 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Great, thanks!

Thanks, everyone!

You need to log in before you can comment on or make changes to this bug.