1561748 - Fix menulist dropdown arrows after bug 1560556

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Jorg K (CEST = GMT+2)]

12:34:32 - Paenglab: jorgk: Hi, do you have a build from today? It could be that Bug 1560556 affects us too. Does the dropmarker still look correct on menulists?

Is doesn't :-(

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1561748-fix-dropmarker-icons.patch

It wasn't only the menulist dropmarker. This should fix all occurrences of it. Checked on Mac and Windows.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9074463 [details] [diff] [review]
1561748-fix-dropmarker-icons.patch

Review of attachment 9074463 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, seems to work on the ones I tried. Too late for today's Daily, and since it was wrong yesterday, I won't cancel and respin it now.

::: mail/themes/osx/mail/messenger.css
@@ +637,5 @@
>  .button-menubutton-dropmarker {
>    -moz-appearance: none;
>  }
>  
> +button > .button-box > dropmarker::part(icon) {

What happened here? It's Mac, so I can't try it.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1561748-fix-dropmarker-icons.patch

(In reply to Jorg K (GMT+2) from comment #2)

Comment on attachment 9074463 [details] [diff] [review]
1561748-fix-dropmarker-icons.patch

Review of attachment 9074463 [details] [diff] [review]:

+button > .button-box > dropmarker::part(icon) {

What happened here? It's Mac, so I can't try it.

I forgot that we have a button in AB too which has a a bit different structure. Fixed now.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f00b3cb050f3
Fix menulist dropdown arrows after bug 1560556. r=jorgk