Convert foo.indexOf(...) > to foo.includes(...)
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
2.25 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Spotted two files where it might be possible to use foo.includes() instead of foo.indexOf()
See bug 1207363 and bug 1339461 for more information.
For the changes in mail/base/content/msgMail3PaneWindow.js from reading the code it seems to be looking for those headers so not sure why finding them at position zero was invalid.
Comment 2•5 years ago
|
||
(In reply to Ian Neal from comment #1)
For the changes in mail/base/content/msgMail3PaneWindow.js from reading the code it seems to be looking for those headers so not sure why finding them at position zero was invalid.
Very strange, I guess they never occurred at position 0.
Comment 3•5 years ago
|
||
Comment on attachment 9074369 [details] [diff] [review] Use includes() Thanks, I'll land it later, if you don't mind.
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ca15c222cd1e
Convert three 'foo.indexOf(...) >' to 'foo.includes(...)'. r=jorgk DONTBUILD
Updated•5 years ago
|
Description
•