Closed Bug 1561756 Opened 2 years ago Closed 2 years ago

Remove lockFocus call in nsMacSharingService.mm

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

The concept of a "focused view" or of "locking focus on a view" for image drawing is a bit outdated and strange. This patch uses a different API to achieve the same.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/3e22c91c3b04
Convert the NSImage into an NSBitmapImageRep without using lockFocus. r=tnikkel
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

== Change summary for alert #21639 (as of Thu, 27 Jun 2019 14:07:56 GMT) ==

Improvements:

34% build times linux32-shippable opt nightly taskcluster-c5d.4xlarge 6,022.82 -> 3,976.07

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21639

Regressions: 1629533
You need to log in before you can comment on or make changes to this bug.