Closed Bug 1561821 Opened 3 months ago Closed 2 months ago

Enable frame pointers in Rust code when building with --enable-frame-pointers

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

It looks like rust changed its default from emitting frame pointers in versions up to 1.26 to omitting them in version 1.27 and newer. At the same time the default changed, a flag was added to enable them: -Cforce-frame-pointers=yes.

Type: defect → enhancement

As it turns out, the version the minidump-stackwalk tasks use (1.31), is
the first version that actually builds the project: 1.30 and earlier
fail because for some reason, cargo wants to read all Cargo.toml files
in the workspace, including unrelated ones, and barfs on features that
weren't supported until 1.31.

Attachment #9076108 - Attachment description: Bug 1561821 - Enable frame pointers in Rut code when building with --enable-frame-pointers. → Bug 1561821 - Enable frame pointers in Rust code when building with --enable-frame-pointers.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5ea16b65fba1
Bump toolkit/crashreporter's minimum supported rust version. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/d45068799783
Enable frame pointers in Rust code when building with --enable-frame-pointers. r=nalexander
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.