1561821 - Enable frame pointers in Rust code when building with --enable-frame-pointers

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

It looks like rust changed its default from emitting frame pointers in versions up to 1.26 to omitting them in version 1.27 and newer. At the same time the default changed, a flag was added to enable them: -Cforce-frame-pointers=yes.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1561821 - Bump toolkit/crashreporter's minimum supported rust version.

As it turns out, the version the minidump-stackwalk tasks use (1.31), is
the first version that actually builds the project: 1.30 and earlier
fail because for some reason, cargo wants to read all Cargo.toml files
in the workspace, including unrelated ones, and barfs on features that
weren't supported until 1.31.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1561821 - Enable frame pointers in Rust code when building with --enable-frame-pointers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ea16b65fba1
Bump toolkit/crashreporter's minimum supported rust version. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/d45068799783
Enable frame pointers in Rust code when building with --enable-frame-pointers. r=nalexander

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5ea16b65fba1
https://hg.mozilla.org/mozilla-central/rev/d45068799783