Remove OpenH264 plugin from about:addons
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox-esr60 wontfix, firefox-esr68 verified, firefox67 wontfix, firefox67.0.1 wontfix, firefox68 wontfix, firefox69 verified, firefox70 verified)
People
(Reporter: eliza.balazs, Assigned: andrei.a.lazar)
References
Details
(Whiteboard: [fennec68.1])
Attachments
(1 file, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr68+
|
Details | Review |
Environment:
Device: Nexus 6P (Android 8.1.0);
Build:
Nightly 68.0a1 (2019-06-25);
Nightly 69.0a1 (2019-06-26) from mozilla-central;
Beta 68.0b13;
Steps to reproduce:
- Launch Fennec and go to about:addons;
- Observe the Add-ons page options;
Expected result:
OpenH264 plugin should not be displayed due to Bug 1548679.
Actual result:
OpenH264 plugin is displayed on the Add-ons page.
Notes:
- The functionality of the OpenH264 plugin option was removed in Bug 1548679 and this bug was created for removing it from the UI.
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Comment on attachment 9074503 [details]
Bug 1561844 - Disable and hide OpenH264 from about:addons. r=petru
Beta/Release Uplift Approval Request
- User impact if declined: Bug 1548679 disabled this functionality but it is still visible in about:addons, creating a direct dependency on this issue.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Open about:addons and check if OpenH264 is still visible.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is only changing the preference which controls if the OpenH264 plugin is visible and enabled.
- String changes made/needed:
Updated•5 years ago
|
Comment 3•5 years ago
|
||
We need to show this UI for users that still have Openh264 installed. For users that are new and do not have OpenH264 the UI should not appear.
Comment 4•5 years ago
|
||
The current patch is not acceptable as we cannot disable the UI for all users.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 5•5 years ago
|
||
My bad, I was under the impression that we want to remove it completely. I have canceled the landing of the patch and am looking further into how this can be achieved, thanks!
Assignee | ||
Comment 6•5 years ago
|
||
Assigning myself to this since Vlad fully booked with Fenix work.
Updated•5 years ago
|
Comment 7•5 years ago
|
||
I think a good way to check if the plugin is available or not is to check if the plugin version number is set. If the plugin is not available the version number is $value$. Check bug 1548679 for more details.
Comment 8•5 years ago
|
||
Setting firefox-esr68=affected status flag because we want to track this for Fennec ESR 68.
Assignee | ||
Comment 9•5 years ago
|
||
Removed OpenH264 plugin from addons list for users that doesn't have it installed.
Assignee | ||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbe14fc96195
Remove OpenH264 plugin from about:addons r=VladBaicu
Comment 11•5 years ago
|
||
Pushed by nerli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23bcedcc2c56 ES lint failure fix CLOSED TREE
Comment 13•5 years ago
|
||
Andrei, I think those eslint warnings were fixed by Noemi in comment 11.
Assignee | ||
Comment 14•5 years ago
|
||
Sorry, we clashed in mid-air, mb.
Comment 15•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bbe14fc96195
https://hg.mozilla.org/mozilla-central/rev/23bcedcc2c56
Comment 16•5 years ago
|
||
Andrei, we should uplift your about:addons fix to Fennec ESR 68.1 (and probably 69 Beta for consistency). We don't need this fix for the Fennec ESR 68.0.x dot release.
Assignee | ||
Comment 17•5 years ago
|
||
Comment on attachment 9076517 [details]
Bug 1561844 Remove OpenH264 plugin from about:addons r=VladBaicu
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Users may still be able to see the disabled addon which may be confusing for some users.
- User impact if declined: Bug 1548679 disabled this functionality but it is still visible in about:addons, creating a direct dependency on this issue.
- Fix Landed on Version:
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is only changing the preference which controls if the OpenH264 plugin is visible and enabled.
- String or UUID changes made by this patch:
Comment 18•5 years ago
|
||
Comment on attachment 9076517 [details]
Bug 1561844 Remove OpenH264 plugin from about:addons r=VladBaicu
Improves a confusing UX situation for users without the OpenH264 plugin. Approved for Beta and Fennec 68.1b2.
Comment 19•5 years ago
|
||
bugherder uplift |
Comment 20•5 years ago
|
||
bugherder uplift |
Comment 21•5 years ago
•
|
||
Hi, the issue does not reproduce:
With devices for Fennec-ESR - Beta 68.1b2 - Build1:
- Google Pixel (Android Q)
- Sony Xperia Z3 (Android 5.1.1)
- Huawei MediaPad M3 Lite 10 (Android 7)
- Nexus 9 (Android 7.1.1)
- Samsung Galaxy Tab S3 (Android 8)
With device - Sony Xperia Z3 (Android 5.1.1) on Beta 69.0b5
With device - Sony Xperia Z3 (Android 5.1.1) on Nightly 70.0a1(2019-07-16)
I will update the ticket as Verified
Updated•5 years ago
|
Comment 22•5 years ago
•
|
||
Hi, verified as fixed on Firefox 68.1 with Google Pixel 3 Xl (Android 9), Samsung Galaxy Note 9 (Android 8.1.0) and Sony Xperia Z5 (Android 7.0) with Firefox RC 68.1.
I will remove the whiteboard flag.
Updated•3 years ago
|
Description
•