1561866 - Move AllocPolicy instances where possible

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jon Coppeard (:jonco)]

Most of our data structures are templated on an AllocPolicy type that is responsible for allocating/freeing memory. Instances of this type are passed by value between data structure constructors and may end up being copied several times.

We should allow these to be moved where possible. This is useful for bug 1395509 where ZoneAllocPolicy is used to track allocated memory.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1561866 - Move alloc policies where possible r=jwalden?

Patch to use std::move when passing AllocPolicy instances to constructors. This also fixes HashTable move constuction/assignment that previously PodAssigned the whole object including the AllocPolicy base.

Depends on D35798

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1621ba12b292
Move alloc policies where possible r=jwalden

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1621ba12b292

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b1b5ac83037
Refactor HashTable move constructor/assignment operator as per review comments, missed from previous push r=jwalden

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4b1b5ac83037