1561890 - Add an accessible label to the toolbox container

Status: NEW

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to bug 1548076.
We are allowing users to move the focus to the toolbox container so that clicking on an empty area of the toolbox still moves the focus from the content page to devtools.

However we don't have any accessibility label defined on this container so it might be confusing for users using screen readers. We should add an aria-label on #toolbox-container

https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.xul#30

Comment 1

[Julian Descottes [:jdescottes]]

Hi Herpiko, would you like to take this follow-up bug :) ?

What needs to be done:

• create a new localized string in https://searchfox.org/mozilla-central/source/devtools/client/locales/en-US/toolbox.dtd
• add a new aria-label attribute on the toolbox container, the value should be the localized string's key (label="&key.of.the.new.string;")

For the new localized string, try to follow the example of the other strings in the DTD file and reuse the same kind of pattern (with localization note etc...).

Comment 2

[Herpiko Dwi Aguno]

Ok, please assign this to me.

Comment 3

[Julian Descottes [:jdescottes]]

Thank you! needinfo me if you need any help with this

Comment 4

[Patrick Brosset <:pbro>]

Hi Herpiko, I'm just checking in, do you still intend to work on this bug? If so and you just need more time, no worries at all.