Closed Bug 1561901 Opened 4 months ago Closed 3 months ago

Implement smart highlighting for search suggestions

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.1 - Jul 8 - 21
Tracking Status
firefox70 --- fixed

People

(Reporter: dao, Assigned: harry)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

From https://mozilla.invisionapp.com/share/DNSDVW5E8QK#/screens/367251846_Photon_Design_Update:

"for search suggestions, we'll highlight the part you haven't typed, bringing focus to the suggested piece"

I haven't fully researched this -- this needs to be done either in payloadAndSimpleHighlights or in the code calling that function. adw implemented that and might have an opinion about how to best approach this.

This is to be implemented in-product without a pref.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Attachment #9075978 - Attachment description: Bug 1561901 - Implement smart highlighting for search suggestions by adding a reverseMatches parameter to UrlbarUtils.getTokenMatches. r?adw → Bug 1561901 - Implement smart highlighting for search suggestions by adding a reverseMatches parameter to UrlbarUtils.getTokenMatches. r?dao
Iteration: --- → 70.1 - Jul 8 - 21
Attachment #9075978 - Attachment description: Bug 1561901 - Implement smart highlighting for search suggestions by adding a reverseMatches parameter to UrlbarUtils.getTokenMatches. r?dao → Bug 1561901 - Implement smart highlighting for search suggestions by adding a UrlbarUtils.HIGHLIGHT enum. r?dao
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75685314e8e2
Implement smart highlighting for search suggestions by adding a UrlbarUtils.HIGHLIGHT enum. r=dao
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.