1561927 - Scrolling on a Chromebook trackpad just selects text

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Tiger Oakes]

User Agent: Mozilla/5.0 (X11; CrOS x86_64 12105.68.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.88 Safari/537.36

Steps to reproduce:

On a Chromebook, try scrolling on the page using two fingers on a trackpad.

Actual results:

Text starts getting selected from wherever the cursor rests on the page.

Expected results:

The page should scroll.

(It still kind of works, because eventually you start selecting text outside the viewport and the page shifts for that. Selecting is the reverse of the scrolling direction, however.)

Comment 1

[Chris Peterson [:cpeterson]]

Is the two finger scrolling gesture being reported as a scroll wheel event? Randall says scrolling with a mouse scroll wheel works correctly, so this problem is specifically related to the trackpad gesture.

Comment 2

[Randall Barker [:rbarker]]

I've verified that a bluetooth mouse works as expected in Fenix Preview release. The scroll wheel scrolls the content. So maybe the two finger scroll is not being sent as an android scroll wheel event on chromebooks?

Comment 3

[Tiger Oakes]

It looks like once one finger is on the trackpad, the second is only used for selection. Any movement with the second finger selects text in the corresponding direction.

Comment 4

[Randall Barker [:rbarker]]

Also, looks like user agent is being spoofed which can change page behavior. Or this isn't geckoview.

Comment 5

[Tiger Oakes]

I tested on https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event#Scaling_an_element_via_the_wheel and couldn't get a wheel event to fire using the trackpad.

Comment 6

[Chris Peterson [:cpeterson]]

Tiger originally filed this bug in the Fenix issue tracker: https://github.com/mozilla-mobile/fenix/issues/3708

Comment 7

[Emily Toop (:fluffyemily)]

Also, looks like user agent is being spoofed which can change page behavior. Or this isn't geckoview.

:rbarker are you saying that this isn't a GV issue, or that we need to investigate whether the user agent spoofing is changing the page behaviour? Is there more investigation we need to do here?

Comment 8

[Randall Barker [:rbarker]]

(In reply to Emily Toop (:fluffyemily) from comment #7)

Also, looks like user agent is being spoofed which can change page behavior. Or this isn't geckoview.

:rbarker are you saying that this isn't a GV issue, or that we need to investigate whether the user agent spoofing is changing the page behaviour? Is there more investigation we need to do here?

I'm saying based on the UA, either Gecko is UA spoofing or it is actually WebView and not GeckoView.

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Tiger Oakes from comment #0)

User Agent: Mozilla/5.0 (X11; CrOS x86_64 12105.68.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.88 Safari/537.36

(In reply to Randall Barker [:rbarker] from comment #4)

Also, looks like user agent is being spoofed which can change page behavior. Or this isn't geckoview.

I think Tiger's comment 0 lists a Chrome UA because he probably filed this bug using Chrome on his Chromebook. He said in the Fenix issue that he can reproduce this bug in Fenix, R-B, and Focus+GV. If he switches Focus from GV back to WebView, then the text selection works correctly.

Comment 10

[Randall Barker [:rbarker]]

Then sounds like either the native android scroll wheel events are not being passed to GeckoView's PanZoomController or the chromebook isn't generating them. We use scroll wheel events in FxR to scroll content and do not have this problem.

Comment 11

[Chris Peterson [:cpeterson]]

Do we need to detect two-finger drag events and then synthesize scroll events for Gecko APZ? Would that be the responsibility of GV or A-C?

Comment 12

[kopp.dev]

Also happening on ChromeOS Version 87.0.4280.142, 64bit, with Firefox 82.0.2 (64-bit) flatpacked.

Comment 13

[kopp.dev]

Not happening on same ChromeOS without Linux emulation. 85.0.0-beta.7 (Build #2015786831), AC: 70.0.11, 3d692de26, GV: 85.0-20210110185809, AS: 67.2.0.

Comment 14

[Makoto Kato [:m_kato]]

Chromebook fires invalid motion events that is no button state. See https://bugs.chromium.org/p/chromium/issues/detail?id=704051

Comment 15

[Makoto Kato [:m_kato]]

Attachment: Bug 1561927 - Ignore weird motion event on Chrome OS. r=#geckoview-reviewers

Android app on Chrome OS doesn't use scroll event on touch pad scroll. And
this generate wired mouse event via it.

So we should add a workaround like Blink (https://crbug.com/704051).

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4b5e3c2ae1e
Ignore weird motion event on Chrome OS. r=geckoview-reviewers,agi

Comment 17

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d4b5e3c2ae1e