1561929 - slider.snapMultiplier should be zero (disabled) by default on Linux

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Kestrel]

The default value of slider.snapMultiplier on Linux has changed from 0 to 6 recently. This causes the scrollbar position to reset when dragged too far away which is not standard behavior for GTK applications.

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d8a83a5f0fb9165f97d8000976bb2241d44cda34&tochange=c0056880ec37b2845b831dbe53e3197fa696e4a5

Regressed by Bug 1558358.

Comment 1

[Nicholas Nethercote [inactive]]

This pref was a mess before bug 1558358. It appeared in StaticPrefList.h and then appeared twice in all.js (which overrides the one in StaticPrefList.h). jya and I discussed this in the bug. What we missed is that the second appearance in all.js is within a #ifdef XP_WIN block that spans several hundred lines, and is thus easy to overlook.

The fix for this should occur in StaticPrefList.h; a #ifdef XP_WIN can be applied to the slider.snapMultiplier entry in there. There is no need for an entry in all.js.

Comment 2

[Nicholas Nethercote [inactive]]

But thank you for the report :)

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1561929 - Fix slider.snapMultiplier pref values. r=jya

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ed70f1397e9
Fix slider.snapMultiplier pref values. r=jya

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8ed70f1397e9