1561944 - Implement nsINetworkLinkService.networkID for Android

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Valentin Gosu [:valentin] (he/him)]

The implementation should probably be similar to that of isNetworkLinkUp, calling into Java code to get the network info.

https://searchfox.org/mozilla-central/rev/06bd14ced96f25ff1dbd5352cb985fc0fa12a64e/netwerk/system/android/nsAndroidNetworkLinkService.cpp#29
https://searchfox.org/mozilla-central/rev/06bd14ced96f25ff1dbd5352cb985fc0fa12a64e/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java#1150

I found these APIs that seem to get you all networks and a "handle" for each (not sure of the handle is unique though. we might have to compute a uuid based on the network attributes).

https://developer.android.com/reference/android/net/ConnectivityManager.html#getAllNetworks()
https://developer.android.com/reference/android/net/Network.html#getNetworkHandle()

Comment 1

[Kershaw Chang [:kershaw]]

I am not sure how important this bug is.
NI Nhi for adjusting the priority.

Comment 2

[Nhi Nguyen (:nhi)]

this needs to go into Fx70

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Changing to corp confidential temporarily (till after Sept 10) on Tony and elan's request.

Comment 4

[Michal Novotny [:michal]]

Attachment: Bug 1561944 - Implement nsINetworkLinkService.networkID for Android

Patch changes nsAndroidNetworkLinkService so it uses NetlinkService for network ID calculation as well as for notifications about network changes.

Comment 5

[Nhi Nguyen (:nhi)]

Valentin, could you review the patch? This is for 71.

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Sure, I'll try to do it by tomorrow evening.

Comment 7

[Andreea Pavel [:apavel]]

Landed here: https://hg.mozilla.org/integration/autoland/rev/a6dff66393c94abda1e9abaee94fff8201a6ab48

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/a6dff66393c94abda1e9abaee94fff8201a6ab48
https://hg.mozilla.org/mozilla-central/rev/a6dff66393c9