1561964 - Re-enable tests on android in dom/security

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Lots of tests are disabled on Android in dom/security. Most of these tests actually work so we can just enable them!

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Try looks reasonably green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fff84954b49e4d0ff8ca53658d45056d1ddaf47 will send for review soon.

Comment 2

[Chris Peterson [:cpeterson]]

Setting [geckoview:fenix:m7] whiteboard tag because we should re-enable these dom/security tests for the next Fenix milestone (M7).

69=fix-optional because I don't know if we would want to (or easily be able to) enable these tests in 69 Beta after they're green on 70 Nightly.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1561964 - Re-enable all tests in dom/security/test on Android.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c06eb27d0c64
Re-enable all tests in dom/security/test on Android. r=ckerschb

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4842b8976c2
Backed out changeset c06eb27d0c64 for mochitest failures CLOSED TREE

Comment 6

[Alexandru Michis [:malexandru]]

Backed out changeset c06eb27d0c64 for mochitest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/d4842b8976c26b9ab64ba57e95ae41281b7bcaa3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=b3b7813eb4a6f65510baa351bf06b64322d2d878&fromchange=c06eb27d0c6473f15811c51a4dc686aa45a34b0b&searchStr=mochitest&selectedJob=256597605

Failure logs:

• In test_upgrade_insecure.html: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=256597605&repo=autoland&lineNumber=5257
• In test_assert_about_page_no_csp.html: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=256600644&repo=autoland&lineNumber=1515

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

oops I accidentally enabled those tests on Mac too. Running a try to verify my new fix works as intended. Thanks.

Comment 9

[Chris Peterson [:cpeterson]]

[geckoview:fenix:m7] bugs should be priority P1.

I'm editing a bunch of GeckoView bugs. If you'd like to filter all this bugmail, search and destroy emails containing this UUID:

e88a5094-0fc0-4b7c-b7c5-aef00a11dbc9

Comment 10

[Chris Peterson [:cpeterson]]

Agi says there are some issues skipping tests. He has some patches to test.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92848bd0c1e0
Re-enable all tests in dom/security/test on Android. r=ckerschb

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/92848bd0c1e0

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out changeset 92848bd0c1e0 (Bug 1561964) for dom/security android mochitest failures

This was backed out because it triggered some mochitest failures on central:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=mochitest&revision=03cc4203321f4f63d08bf290d697e433b72be972&selectedJob=264139018

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264139018&repo=mozilla-central&lineNumber=1672

Backout: https://hg.mozilla.org/integration/autoland/rev/17167e60ae2a5b3b4df16bb885011bdf285ef956

Comment 14

[[ex-Mozilla] Agi Sferro | :agi]

Ah, looks like this test fails on Fennec. We're turning off that in 1577037, so I'll just wait for that bug to be fixed and land this after that.

Comment 15

[Chris Peterson [:cpeterson]]

Adding this bug to GV's September sprint since mozilla-central tests for Fennec will stop running next week (bug 1577037).

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e17369fbc82
Re-enable all tests in dom/security/test on Android. r=ckerschb

Comment 17

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0e17369fbc82