1562050 - Quantum bar : cannot scroll searches after clicking show history button

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Pablo]

[Description:]
In quantum bar, i cannot select any searches after clicking the show history button

[Environment:]
69.0a1 Nightly Ubuntu 18.04 / Macos 10.14.4 / Windows10 all affected
68.0b13 Beta Ubuntu 18.04 / Macos 10.14.4 / Windows10 all affected
67.0.4 Release not affected because quantum bar is turned off by default in about:config

[Steps:]
-Launch firefox with clean profile
-Open new tab, type www.youtube.com , hit enter
-Youtube site loads.
-With your mouse, click on the Down arrow (show history button, its hidden, you have to hover over it) (button is next to page actions / save to pocket/ bookmark)
-List of search suggestions appear
-Press down key on your keyboard

[Actual Result:]
On ubuntu: search suggestion sites appear, but if you press down key it scrolls the page
on Windows: search suggestion site appears, but if you press down key it does nothing
on MacOs: search suggestion site appears, but if you press down key it does nothing

[Expected Result:]
when you press show history button, the site should be highlighted, and then you press down key on keyboard you can navigate to one of the searches.

[Note:]
Since this does not reproduce with awesome-bar & Fx67, don't think it's a recent regression.
this happens with quantum bar, does not happen with awesome bar

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Pablo from comment #0)

on Windows: search suggestion site appears, but if you press down key it does nothing

It scrolls the page for me, also on Windows 10...

[Expected Result:]
when you press show history button, the site should be highlighted, and then you press down key on keyboard you can navigate to one of the searches.

Well, the site should not be preselected, but it should indeed highlight the first entry on DOWN.

Comment 2

[Drew Willcoxon :adw]

Probably just need to focus the input? https://searchfox.org/mozilla-central/rev/f91bd38732d4a330eba4e780812274b98eb81274/toolkit/content/widgets/autocomplete.xml#340

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1562050 - Quantumbar: When the history dropmarker is clicked, focus the input.

I don't really think this needs a test, but let me know if you think so.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b180b228f558
Quantumbar: When the history dropmarker is clicked, focus the input. r=dao

Comment 5

[Dão Gottwald [:dao]]

If we want to fix this before release then this isn't a P3...

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

It may be late for uplift to 68. Worth asking rel-man sooner than later. Please file the uplift request.

Comment 7

[Drew Willcoxon :adw]

Yeah I figured this would just wait to 69 given how late in the cycle it is.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b180b228f558

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Drew Willcoxon :adw from comment #7)

Yeah I figured this would just wait to 69 given how late in the cycle it is.

We should try to uplift, if possible, there's still 1 week before the merge. while it's not the best time to do it, the urlbar is important enough to work properly in most cases.

Comment 10

[Drew Willcoxon :adw]

Attachment: Beta patch

Beta/Release Uplift Approval Request

• User impact if declined: Quantumbar debuts in 68 so it would be nice to fix this for 68.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a one-line patch that just focuses the urlbar when the user clicks the dropdown arrow in the urlbar. There's not much risk that this will accidentally affect anything other than clicking the dropmarker. I've also tested the fix locally on Beta.
• String changes made/needed: None

Comment 11

[Alexandru Trif, Desktop QA [:atrif]]

Hello!
Reproduced the issue using Firefox 69.0a1 (20190627214735) on Windows 10x64, macOS 10.14, Ubuntu 18.04.
The issue is verified fixed with Firefox 69.0a1 (20190630214222) on Windows10x64, macOS 10.14 and Ubuntu 18.04.

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9074659 [details]
Bug 1562050 - Quantumbar: When the history dropmarker is clicked, focus the input.

quantumbar fix for 68.0 rc1

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/8bcc650e2d69

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/8bcc650e2d69

Comment 15

[Alexandru Trif, Desktop QA [:atrif]]

Hello,
The issue is verified fixed using Firefox 68.0 (20190701181138) on Windows 10x64, Ubuntu 18.04 and macOS 10.14.

Comment 16

[Alexandru Trif, Desktop QA [:atrif]]

Hi,
The issue is verified fixed using Firefox 68.0esr (20190704173630) on Windows 10x64, Ubuntu 18.04 and macOS 10.14.