Closed Bug 1562111 Opened 1 year ago Closed 1 year ago

Build error with "ac_add_options --disable-sandbox" on Windows: toolkit/xre/nsXREDirProvider.cpp(1221,17): error: no member named 'widget' in namespace 'mozilla'

Categories

(Core :: Security: Process Sandboxing, defect, P2)

x86_64
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 69+ fixed
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 + fixed

People

(Reporter: kamidphish, Assigned: kamidphish)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:
Try to build with "ac_add_options --disable-sandbox" on Windows

25:05.10 In file included from c:/Mozilla/obj-ff64-opt/toolkit/xre/Unified_cpp_toolkit_xre1.cpp:11:
25:05.11 c:/Mozilla/gecko/toolkit/xre/nsXREDirProvider.cpp(1221,17): error: no member named 'widget' in namespace 'mozilla'
25:05.13 if (!mozilla::widget::WinUtils::ResolveJunctionPointsAndSymLinks(
25:05.14 ~~~~~~~~~^
25:05.32 1 error generated.

Status: NEW → RESOLVED
Closed: 1 year ago
No longer depends on: 1555319
Resolution: --- → DUPLICATE
Duplicate of bug: 1561915

All uses of WinUtils::ResolveJunctionPointsAndSymLinks are protected by
#if defined(XP_WIN) && defined(MOZ_SANDBOX)

Assignee: nobody → dglastonbury
Blocks: 1561915
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

Why did you reopen this bug instead of just posting the patch to the bug that was opened earlier today for the issue?

Flags: needinfo?(dglastonbury)
Attachment #9074686 - Attachment description: Bug 1562111 - WinUtils::ResolveJunctionPointsAndSymLinks requires #ifdef MOZ_SANDBOX. → Bug 1562111 - Unconditionally include WinUtils.h on Windows.
Duplicate of this bug: 1561915
No longer blocks: 1561915

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Priority: P3 → P2

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

Why did you reopen this bug instead of just posting the patch to the bug that was opened earlier today for the issue?

I had already pushed a patch to this bug before discovering it was closed. I thought it was better to keep the bug and make the other block on this instead of juggling patches.

Flags: needinfo?(dglastonbury)
Pushed by dglastonbury@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62cc1336cd81
Unconditionally include WinUtils.h on Windows. r=bobowen
Status: ASSIGNED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

We're going to want this on ESR68 once bug 1555319 gets uplifted there.

Please nominate this for ESR68 approval when you get a chance.

Flags: needinfo?(dglastonbury)

Comment on attachment 9074686 [details]
Bug 1562111 - Unconditionally include WinUtils.h on Windows.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Requested uplift nomination by :ryanvm
  • User impact if declined: None. The change fixes compilation when --disable-sandbox is passed on Windows. This bug causes permafailing Windows ASAN builds.
  • Fix Landed on Version: 69
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change isn't risky as it is a compile time failure. It only changes the ability to compile when --disable-sandbox is passed. The code is compiled and tested when sandbox is enabled.
  • String or UUID changes made by this patch: None
Flags: needinfo?(dglastonbury)
Attachment #9074686 - Flags: approval-mozilla-esr68?

Comment on attachment 9074686 [details]
Bug 1562111 - Unconditionally include WinUtils.h on Windows.

Fixes build bustage when --disable-sandbox is used. NPOTB for builds we ship. Approved for 68.1esr.

Attachment #9074686 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
You need to log in before you can comment on or make changes to this bug.