1562111 - Build error with "ac_add_options --disable-sandbox" on Windows: toolkit/xre/nsXREDirProvider.cpp(1221,17): error: no member named 'widget' in namespace 'mozilla'

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P2)

Description

[u480271]

STR:
Try to build with "ac_add_options --disable-sandbox" on Windows

25:05.10 In file included from c:/Mozilla/obj-ff64-opt/toolkit/xre/Unified_cpp_toolkit_xre1.cpp:11:
25:05.11 c:/Mozilla/gecko/toolkit/xre/nsXREDirProvider.cpp(1221,17): error: no member named 'widget' in namespace 'mozilla'
25:05.13 if (!mozilla::widget::WinUtils::ResolveJunctionPointsAndSymLinks(
25:05.14 ~~~~~~~~~^
25:05.32 1 error generated.

Comment 2

[u480271]

Attachment: Bug 1562111 - Unconditionally include WinUtils.h on Windows.

All uses of WinUtils::ResolveJunctionPointsAndSymLinks are protected by
#if defined(XP_WIN) && defined(MOZ_SANDBOX)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Why did you reopen this bug instead of just posting the patch to the bug that was opened earlier today for the issue?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 6

[u480271]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

Why did you reopen this bug instead of just posting the patch to the bug that was opened earlier today for the issue?

I had already pushed a patch to this bug before discovering it was closed. I thought it was better to keep the bug and make the other block on this instead of juggling patches.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62cc1336cd81
Unconditionally include WinUtils.h on Windows. r=bobowen

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/62cc1336cd81

Comment 9

[Intermittent Failures Robot]

7 failures in 4409 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 7

Platform breakdown:

• windows2012-64: 4
• win64-asan-reporter: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1562111&startday=2019-06-24&endday=2019-06-30&tree=all

Comment 10

[Ryan VanderMeulen [:RyanVM]]

We're going to want this on ESR68 once bug 1555319 gets uplifted there.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR68 approval when you get a chance.

Comment 12

[u480271]

Comment on attachment 9074686 [details]
Bug 1562111 - Unconditionally include WinUtils.h on Windows.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Requested uplift nomination by :ryanvm
• User impact if declined: None. The change fixes compilation when --disable-sandbox is passed on Windows. This bug causes permafailing Windows ASAN builds.
• Fix Landed on Version: 69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change isn't risky as it is a compile time failure. It only changes the ability to compile when --disable-sandbox is passed. The code is compiled and tested when sandbox is enabled.
• String or UUID changes made by this patch: None

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9074686 [details]
Bug 1562111 - Unconditionally include WinUtils.h on Windows.

Fixes build bustage when --disable-sandbox is used. NPOTB for builds we ship. Approved for 68.1esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/f68f9e47a783