Closed Bug 1562161 (textbox-to-html-input) Opened 10 months ago Closed 6 months ago

[meta] convert <textbox> usages in Thunderbird to HTML <input>

Categories

(Thunderbird :: General, task, P1)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: mkmelin, Assigned: aleca)

References

Details

(Keywords: meta)

This is the Thunderbird bug for bug 1547372.
For inspiration on how, look at patches in bugs dependent on that one.

Alex, please file dependent bugs for this one, in appropriate chunks.

Some stats before filling up this meta bug

  • 306 <textbox>
  • 7 createXULEelement("textbox")
  • 1 getElementsByTagName("textbox")
  • 7 closest("textbox")
  • 10 querySelector("textbox")
  • 1 querySelectorAll("textbox")
  • 7 conditions == "textbox"
  • 53 textbox CSS declarations

Let's ignore for now type="autocomplete" and is="search-textbox" as they will be soon converted into CE

Depends on: 1562994
Depends on: 1562997
Depends on: 1562998
Depends on: 1563000
Depends on: 1563001
Depends on: 1563002
Depends on: 1563003
Depends on: 1563005
Depends on: 1563009
Depends on: 1563079
Depends on: 1563083
Depends on: 1563084
Depends on: 1563086
Depends on: 1563089
Depends on: 1563092
Depends on: 1563095
Depends on: 1563097
Depends on: 1563098
Depends on: 1563102
Depends on: 1563103
Depends on: 1563104
Depends on: 1563105
Depends on: 1563106
Depends on: 1563107
Depends on: 1563108
Depends on: 1563109
Depends on: 1563110
Depends on: 1563111
Depends on: 1563112
Depends on: 1563113
Depends on: 1563115
Depends on: 1563117
Depends on: 1563118
Depends on: 1563119
Depends on: 1563120
Depends on: 1563121
Depends on: 1563122
Depends on: 1563124
Depends on: 1563125

This is a first batch that includes almost everything inside the mail/ and calendar/ directory.
Should we take care of the mailnews/ directory as well? I see some repeated files that we're not using.

Flags: needinfo?(mkmelin+mozilla)

So many bugs? For example, woudn't one bug for editor/ have been enough? There could be multiple patches if necessary. I find this a little hard to manage.

I tried to split the bug based on sections and purpose, and I didn't want to have too many files to track in one single bug.
I tried to follow the logic of the de-xbl meta bug and keep small changesets.
If you think this is wrong I'm happy to update it.

Well, some bugs are for a one line change, like bug 1563104. I haven't looked in detail, but as I said, I would have expected one bug per directory, like for example bug 1551704 and its dependents.

(In reply to Alessandro Castellani (:aleca) from comment #2)

Should we take care of the mailnews/ directory as well? I see some
repeated files that we're not using.

Yes. We're using everything in mailnews (unlike editor/). If you find something we don't use, that would be a bug.

For size of bugs, I think you can go which ever way is easiest.

Flags: needinfo?(mkmelin+mozilla)
Depends on: 1565075
Priority: -- → P2
Priority: P2 → --

Something to watch out for is not forgetting to import the relevant scripts (globalOverlay.js and editMenuOverlay.js) if they're not already there when doing the conversion, otherwise the edit context menu will stop working on those pages. See bug 1565921.

Thanks for the heads up!

Depends on: 1573678
Alias: textbox-to-html-input

Where is the bug for mailnews? calendar, chat and mail (was editor) seem to be well covered:
https://searchfox.org/comm-central/search?q=%3Ctextbox&case=false&regexp=false&path=%5Emailnews%2F

I think there isn't any specific bugs filed just yet. I'll look at some of the textboxes now since bug 1513325 is almost there.

Depends on: 1584450
Depends on: 1584454
Depends on: 1584457
Depends on: 1584458
Depends on: 1584459
Depends on: 1584460
Depends on: 1584462
Depends on: 1584463

mailnews is now also filed, I think.

Priority: -- → P1
Depends on: 1584724
No longer depends on: 1584724
Depends on: 1585617
Depends on: 1585822
No longer depends on: 1573678

Looks like we're getting really close, the last bug already has r+ with just a few nits to fix. That said, I don't see that Mozilla can drop the binding in the immediate future, it's still all over the place in their tests:
https://searchfox.org/mozilla-central/search?q=%3Ctextbox&case=false&regexp=false&path=

But I think that all has patches... somewhere. Bug 1513325 is now accepted and ready to land. So it shouldn't be long.

I think you missed https://phabricator.services.mozilla.com/D47986 ;-) - That doesn't look ready at all.
EDIT: OK, there's also bug 1586141, but I don't think it's done yet.

Bug 1566674 is taking care of the test removals in the dependencies. I suspect it'll be done by the end of next week, once that done, I'll just trigger https://phabricator.services.mozilla.com/D38955 for landing.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.