1562161 - (textbox-to-html-input) [meta] convert <textbox> usages in Thunderbird to HTML <input>

Status: RESOLVED FIXED

(Thunderbird :: General, task, P1)

Description

[Magnus Melin [:mkmelin]]

This is the Thunderbird bug for bug 1547372.
For inspiration on how, look at patches in bugs dependent on that one.

Alex, please file dependent bugs for this one, in appropriate chunks.

Comment 1

[Alessandro Castellani [:aleca]]

Some stats before filling up this meta bug

• 306 <textbox>
• 7 createXULEelement("textbox")
• 1 getElementsByTagName("textbox")
• 7 closest("textbox")
• 10 querySelector("textbox")
• 1 querySelectorAll("textbox")
• 7 conditions == "textbox"
• 53 textbox CSS declarations

Let's ignore for now type="autocomplete" and is="search-textbox" as they will be soon converted into CE

Comment 2

[Alessandro Castellani [:aleca]]

This is a first batch that includes almost everything inside the mail/ and calendar/ directory.
Should we take care of the mailnews/ directory as well? I see some repeated files that we're not using.

Comment 3

[Jorg K (CEST = GMT+2)]

So many bugs? For example, woudn't one bug for editor/ have been enough? There could be multiple patches if necessary. I find this a little hard to manage.

Comment 4

[Alessandro Castellani [:aleca]]

I tried to split the bug based on sections and purpose, and I didn't want to have too many files to track in one single bug.
I tried to follow the logic of the de-xbl meta bug and keep small changesets.
If you think this is wrong I'm happy to update it.

Comment 5

[Jorg K (CEST = GMT+2)]

Well, some bugs are for a one line change, like bug 1563104. I haven't looked in detail, but as I said, I would have expected one bug per directory, like for example bug 1551704 and its dependents.

Comment 6

[Magnus Melin [:mkmelin]]

(In reply to Alessandro Castellani (:aleca) from comment #2)

Should we take care of the mailnews/ directory as well? I see some
repeated files that we're not using.

Yes. We're using everything in mailnews (unlike editor/). If you find something we don't use, that would be a bug.

For size of bugs, I think you can go which ever way is easiest.

Comment 7

[Tim Nguyen :ntim]

Something to watch out for is not forgetting to import the relevant scripts (globalOverlay.js and editMenuOverlay.js) if they're not already there when doing the conversion, otherwise the edit context menu will stop working on those pages. See bug 1565921.

Comment 8

[Alessandro Castellani [:aleca]]

Thanks for the heads up!

Comment 9

[Jorg K (CEST = GMT+2)]

Where is the bug for mailnews? calendar, chat and mail (was editor) seem to be well covered:
https://searchfox.org/comm-central/search?q=%3Ctextbox&case=false&regexp=false&path=%5Emailnews%2F

Comment 10

[Magnus Melin [:mkmelin]]

I think there isn't any specific bugs filed just yet. I'll look at some of the textboxes now since bug 1513325 is almost there.

Comment 11

[Magnus Melin [:mkmelin]]

mailnews is now also filed, I think.

Comment 12

[Jorg K (CEST = GMT+2)]

Looks like we're getting really close, the last bug already has r+ with just a few nits to fix. That said, I don't see that Mozilla can drop the binding in the immediate future, it's still all over the place in their tests:
https://searchfox.org/mozilla-central/search?q=%3Ctextbox&case=false&regexp=false&path=

Comment 13

[Magnus Melin [:mkmelin]]

But I think that all has patches... somewhere. Bug 1513325 is now accepted and ready to land. So it shouldn't be long.

Comment 14

[Jorg K (CEST = GMT+2)]

I think you missed https://phabricator.services.mozilla.com/D47986 ;-) - That doesn't look ready at all.
EDIT: OK, there's also bug 1586141, but I don't think it's done yet.

Comment 15

[Tim Nguyen :ntim]

Bug 1566674 is taking care of the test removals in the dependencies. I suspect it'll be done by the end of next week, once that done, I'll just trigger https://phabricator.services.mozilla.com/D38955 for landing.