1562185 - Cranelift: reorganize baldrdash and allow to change flags with an env variable

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1562185: Reorganize code in Cranelift bindings; r=lth

This introduces a bindings module in the cranelift bindings directory, to make
the roles of different files clearer:

• bindings/low_level.rs (formerly known as baldrapi.rs) contains all the
  bindings automatically generated by bindgen.
• bindings/mod.rs (formerly known as baldrdash.rs) contains all the high-level
  bindings, to be used by the rest of baldrdash.

Some code has been moved to match the roles more consistently; in particular,
nothing in bindings/low_level should be directly used from outer the bindings
directory.

Rustfmt has been run too, which explains a few unrelated changes.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1562185: Convert Baldrdash to a 2018 Rust edition project; r=lth

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1562185: Reorganize Cranelift target ISA configuration; r=lth

• rename the cpu.rs file to isa.rs;
• create a new function for platform-specific flags, and move x86 flags in
  there;

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1562185: Allow to specify Cranelift flags via an env variable; r=lth

This allows using the CRANELIFT_FLAGS environment variable to control some
flags. To start with, this allows selecting the optimization level (opt_level,
which can be set to fastest/default/best as of this date) and
enabling/disabling jump tables.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b972e5914e
Reorganize code in Cranelift bindings; r=lth
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d520df46c0b
Convert Baldrdash to a 2018 Rust edition project; r=lth
https://hg.mozilla.org/integration/mozilla-inbound/rev/12fbcca69b4d
Reorganize Cranelift target ISA configuration; r=lth
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4ed2de25e6d
Allow to specify Cranelift flags via an env variable; r=lth

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f3b972e5914e
https://hg.mozilla.org/mozilla-central/rev/9d520df46c0b
https://hg.mozilla.org/mozilla-central/rev/12fbcca69b4d
https://hg.mozilla.org/mozilla-central/rev/c4ed2de25e6d