Closed Bug 1562229 Opened 3 months ago Closed 2 months ago

Change "current ping" to "current data" in about:telemetry

Categories

(Toolkit :: Telemetry, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: chutten, Assigned: abishekhmjee, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][lang=flt])

Attachments

(1 file)

The page about:telemetry in Firefox shows the currently-unsent data by default. For historical reasons this is labelled "current ping" which has lately proven to be confusing. Let's fix that.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on IRC in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions:
  3. Start working on this bug. You should only need to change the text "current ping" to "current data" in three places in toolkit/locales/en-US/toolkit/about/aboutTelemetry.ftl
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC most hours of most days.
  4. Build your change with mach build and check your changes for adherence to our style guidelines by using mach lint. You should be able to see your changes by running mach run and navigating to about:telemetry.
  5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code. Since this is changing a translated string, we'll also be seeking the review of a someone who knows localisation, but I'll help with that.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

I want to volunteer to help, I've build the artifact version of firefox already. I have also made changes to /mozilla-central/toolkit/locales/en-US/toolkit/about/aboutTelemetry.ftl , and should I make changes to /mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/localization/en-US/toolkit/about/aboutTelemetry.ftl too? I have build my changes mach build and the mach lint reads:

✖ 0 problems (0 errors, 14 warnings)

Thanks!!

Hi! Thanks for taking on this bug.

You shouldn't have to change the file in mozilla-central/obj-x86.... That is the "object directory" where the pieces of your built firefox get put: everything in there was derived from the files in the source directories.

Let me know if you have any questions about getting this set up for review (sounds like you're up to Step 5).

Assignee: nobody → abishekhmjee

Changed all instances of current ping to current data in aboutTelemetry.ftl file

Attachment #9075594 - Attachment description: Bug 1562229 - Change current ping to current data in about:telemetry → Update Bug 1562229 - Change current ping to current data in about:telemetry
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2a000807701
Update Bug 1562229 - Change current ping to current data in about:telemetry r=chutten,fluent-reviewers,flod
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.