Closed Bug 1562233 Opened 5 months ago Closed 5 months ago

Log the CONNECT request head and headers

Categories

(Core :: Networking: HTTP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr68 --- fixed
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

No description provided.

Comment on attachment 9074792 [details]
Bug 1562233 - Add logging of CONNECT requests with headers, add possibility to disable authorization headers sanitization by a preference (default is sanitization enabled), r=dragana!

Beta/Release Uplift Approval Request

  • User impact if declined: Zero impact for users, but for platform developers it can be an invaluable source of information regarding the secure proxy connection problems investigation.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): zero - only affects logging, locally tested
  • String changes made/needed:
Attachment #9074792 - Flags: approval-mozilla-beta?
Pushed by honzab.moz@firemni.cz:
https://hg.mozilla.org/integration/autoland/rev/e289f8f0ab50
Add logging of CONNECT requests with headers, add possibility to disable authorization headers sanitization by a preference (default is sanitization enabled), r=valentin
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9074792 [details]
Bug 1562233 - Add logging of CONNECT requests with headers, add possibility to disable authorization headers sanitization by a preference (default is sanitization enabled), r=dragana!

seems harmless enough, approved for 68 rc1

Attachment #9074792 - Flags: approval-mozilla-release+
Attachment #9074792 - Flags: approval-mozilla-esr68+
Attachment #9074792 - Flags: approval-mozilla-beta?

(In reply to Julien Cristau [:jcristau] from comment #5)

seems harmless enough, approved for 68 rc1

thanks!

You need to log in before you can comment on or make changes to this bug.