Closed Bug 1562258 Opened 4 months ago Closed 4 months ago

3-stage pgo builds build gtests as part of the instrumented build

Categories

(Firefox Build System :: General, task)

task
Not set

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: Gijs, Assigned: mshal)

Details

Attachments

(1 file)

Happened to notice this in the failure output from https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=253803097&resultStatus=testfailed%2Cbusted%2Cexception&revision=455dff329fcc9d8fa0647ca662ce5c8451004c87 -

/builds/worker/workspace/build/src/obj-firefox/dist/include/nscore.h:178:11: error: 'NS_FREE_PERMANENT_DATA' macro redefined [-Werror,-Wmacro-redefined]
make[4]: *** [Unified_cpp_mfbt_tests_gtest0.i_o] Error 1
make[3]: *** [mfbt/tests/gtest/target] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [compile] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Given that we're going to be throwing away and not running any of these tests (I think? Maybe I'm wrong?), and only care about them in the profile-use case (not the profile-generate one), can we disable building these when building with profile-generate? Is there other stuff we could/should disable to speed things up?

Flags: needinfo?(mshal)

(In reply to :Gijs (he/him) from comment #0)

Given that we're going to be throwing away and not running any of these tests (I think? Maybe I'm wrong?), and only care about them in the profile-use case (not the profile-generate one), can we disable building these when building with profile-generate? Is there other stuff we could/should disable to speed things up?

Good catch, yeah I think we can disable that pretty easily in moz.configure. I'll take a look.

Note that we already disable a bunch of automation steps in the profile-generate mozconfigs. Eg: https://searchfox.org/mozilla-central/rev/867cbb1a2b232398616e1aa42f913f37c6cb38e4/browser/config/mozconfigs/linux64/profile-generate#3

But there could be others we're missing.

Assignee: nobody → mshal
Flags: needinfo?(mshal)

Should the profile-generate code just run with --disable-tests ? (Unsure if that ends up affecting something other than gtests.)

We don't run any tests on these builds, since they are just used to
generate the profile data for the final build. We can save some time by
skipping all test related code.

Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4f0c43a164e
Disable tests on instrumented builds; r=froydnj
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.