Closed Bug 1562264 Opened 1 year ago Closed 5 months ago

window.open() from content will open non-Fission windows

Categories

(Core :: Window Management, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Fission Milestone M4
Tracking Status
firefox70 --- fixed

People

(Reporter: kmag, Assigned: kashav)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

window.open() from content should always inherit the Fission settings from its caller, but currently relies on window open flags (which we don't respect for content callers, anyway). We need to fix that.

Priority: -- → P3
Blocks: fission-mochitests
No longer blocks: fission
Fission Milestone: --- → M4
Assignee: kmaglione+bmo → kmadan

Depends on D40836

Depends on D41763

Attachment #9085894 - Attachment is obsolete: true
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/445eadfd8ce3
Propagate remote/fission flags from parent to child for content window.open() calls, r=kmag
https://hg.mozilla.org/integration/autoland/rev/b66eec7d2e55
Update skip-if annotations, r=kmag

There appears to be some inconsistency between the BrowserHost's load context and the parent DocShell's load context (specifically the UseRemoteTabs() value). Confusingly, this only seems to happen in a few Android WPTs. The updated patch fixes this for the time being with a less-strict failure condition.

Flags: needinfo?(kmadan)
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7583023fe753
Propagate remote/fission flags from parent to child for content window.open() calls, r=kmag
https://hg.mozilla.org/integration/autoland/rev/54f2475b0491
Update skip-if annotations, r=kmag
Blocks: 1576269
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1576316
Regressions: 1576456
Blocks: 1576204
No longer regressions: 1576316
You need to log in before you can comment on or make changes to this bug.