1562287 - Allow disabling 3-tier PGO builds on try.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Tom Prince [:tomprince]]

Often times, PGO builds aren't required for testing things (in particular, testing release automation). However, at least when testing release automation, we do need to use the shippable build type.

Provide an option to mach try that will disable using the 3-tier PGO jobs.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1562287: Don't advertise chemspill-prio in try syntax, since it isn't supported; r?ahal

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1562287: Factor out generation of try_task_config; r?ahal

Factor out the logic for calculating try_task_config from push_to_try,
so it can be called only for those selectors that need it.

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1562287: Allow setting other try_task_config settings than `templates`; r?ahal

Templates invoke the morph logic, which is somewhat confusing and inflexible.
Update the machinery to support setting other try_task_config values.

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1562287: Add an option to `mach try` to disable 3-tier PGO; r?ahal,mshal

Often times, PGO builds aren't required for testing things (in particular,
testing release automation). However, at least when testing release automation,
we do need to use the shippable build type.

Add an option to mach try that will disable using the 3-tier PGO jobs.

Comment 5

[Tom Prince [:tomprince]]

Attachment: Bug 1562287: Don't run profile-generation if not required; r?mshal

Don't schedule the first 2 tiers of 3-tier PGO if they aren't going to be used.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d3721c6fad
Don't advertise chemspill-prio in try syntax, since it isn't supported; r=ahal
https://hg.mozilla.org/integration/autoland/rev/08361960eaf4
Factor out generation of try_task_config; r=ahal
https://hg.mozilla.org/integration/autoland/rev/e5c77a0eaa15
Allow setting other try_task_config settings than `templates`; r=ahal
https://hg.mozilla.org/integration/autoland/rev/9e1f67f66b60
Add an option to `mach try` to disable 3-tier PGO; r=mshal,ahal

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e4d3721c6fad
https://hg.mozilla.org/mozilla-central/rev/08361960eaf4
https://hg.mozilla.org/mozilla-central/rev/e5c77a0eaa15
https://hg.mozilla.org/mozilla-central/rev/9e1f67f66b60

Comment 8

[Aki Sasaki (not active)]

Should we remove the None from https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/parameters.py#97 ?

Comment 9

[Tom Prince [:tomprince]]

Attachment: Bug 1562287: [taskgraph] `try_task_config` parameter is now always a `dict`; r?aki

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12c00b976820
[taskgraph] `try_task_config` parameter is now always a `dict`; r=aki

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/12c00b976820

Comment 12

[Tom Prince [:tomprince]]

Attachment: Bug 1562287: [taskgraph] Fix tests around `try_task_config; rs=me

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3183a958ad35
[taskgraph] Fix tests around `try_task_config; rs=me

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3183a958ad35