Closed Bug 1562292 Opened 5 years ago Closed 4 years ago

Support named targeting for remote windows in


(Core :: Window Management, task, P3)




Fission Milestone M4
Tracking Status
firefox70 --- fixed


(Reporter: kmag, Assigned: kmag)


(Blocks 3 open bugs)



(5 files)

Currently, targeting an existing named window in only works for in-process windows, using docshell targetting. We need to change this to use BrowserContext targeting instead, which requires also changing a lot of intermediate code to operate on BrowsingContexts rather than DocShellTreeItems.

Priority: -- → P3
Depends on: 1566186
Fission Milestone: --- → M4
Depends on: 1570207
Type: defect → task

This lets us lookup cross-process targets, but does not yet allow returning or
loading anything into them.

This allows us to actually correctly load URIs into and return BCs for
cross-process named targets. It still leaves a lot of code which needs to
operate directly on DocShells, but it only applies to new windows, which
always start out same-process.

The one exception is the logic to change the opener of an existing
cross-process window targeted by an open() operation, which can't currently be
accomplished outside of the BC's owner process. This will need a follow-up.

Blocks: 1556742
Bug 1562292: Part 1a - Consider requesting context in BrowsingContext lookup methods. r=farre
Bug 1562292: Part 1b.1 - Fix FindWithSpecialName with inaccessible "_parent". r=nika
Bug 1562292: Part 1b.2 - Don't fall back to named lookup for inaccessible special name. r=nika
Bug 1562292: Part 1c - Set BrowsingContext Closed flag at the same time as outer window's. r=nika
Bug 1562292: Part 1d - Move OnePermittedSandboxedNavigator to BrowsingContext. r=nika
Bug 1562292: Part 1e - Use BrowsingContext as target in IsSandboxedFrom(). r=nika
Bug 1562292: Part 1f - Implement BrowsingContext::LoadURI. r=nika
Bug 1562292: Part 2b - Remove unused nsPIWindowWatcher::FindItemWithName method. r=nika
Bug 1562292: Part 2c - Use BrowserContext rather than DocShell to resolve named targets. r=nika
Bug 1562292: Part 2d - Operate on BrowsingContext in most of OpenWindowInternal. r=nika
Bug 1562292: Part 3 - Update test annotations. r=nika
Bug 1562292: Follow-up: Fix bustage in GetWindowByName after dropping removal patch. r=bustage CLOSED TREE
Blocks: 1573956
Regressions: 1574593
Regressions: 1576187
You need to log in before you can comment on or make changes to this bug.