1562292 - Support named targeting for remote windows in window.open()

Status: RESOLVED FIXED

(Core :: Window Management, task, P3)

Description

[Kris Maglione [:kmag]]

Currently, targeting an existing named window in window.open() only works for in-process windows, using docshell targetting. We need to change this to use BrowserContext targeting instead, which requires also changing a lot of intermediate code to operate on BrowsingContexts rather than DocShellTreeItems.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1562292: Part 2a - Remove unused nsIWindowWatcher::GetWindowByName method. r=nika

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1562292: Part 2b - Remove unused nsPIWindowWatcher::FindItemWithName method. r=nika

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1562292: Part 2c - Use BrowserContext rather than DocShell to resolve named targets. r=nika

This lets us lookup cross-process targets, but does not yet allow returning or
loading anything into them.

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1562292: Part 2d - Operate on BrowsingContext in most of OpenWindowInternal. r=nika

This allows us to actually correctly load URIs into and return BCs for
cross-process named targets. It still leaves a lot of code which needs to
operate directly on DocShells, but it only applies to new windows, which
always start out same-process.

The one exception is the logic to change the opener of an existing
cross-process window targeted by an open() operation, which can't currently be
accomplished outside of the BC's owner process. This will need a follow-up.

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1562292: Part 3 - Update test annotations. r=nika

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d513683e1fdbfdb79f5112e9745f2fc0fb4e92fe
Bug 1562292: Part 1a - Consider requesting context in BrowsingContext lookup methods. r=farre

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1fc2382346d163fe18a8fe5d323aafa759e1317
Bug 1562292: Part 1b.1 - Fix FindWithSpecialName with inaccessible "_parent". r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ac7bcafc270b5be3eca84efebcde672fe8fba5
Bug 1562292: Part 1b.2 - Don't fall back to named lookup for inaccessible special name. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/a50f085eb3e6c506fd8e17acb669ef91b6f31390
Bug 1562292: Part 1c - Set BrowsingContext Closed flag at the same time as outer window's. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba987e21b5329d07c3606a65ee0cb76e7bc99a74
Bug 1562292: Part 1d - Move OnePermittedSandboxedNavigator to BrowsingContext. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bffe760e2db5ff009f0d798cbb63b83a68de51b
Bug 1562292: Part 1e - Use BrowsingContext as target in IsSandboxedFrom(). r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/40b61344f0da14f9700a75a8a1c67458e440b68a
Bug 1562292: Part 1f - Implement BrowsingContext::LoadURI. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce60426d7e3152c92c9df31e1657bee4dc928d1b
Bug 1562292: Part 2b - Remove unused nsPIWindowWatcher::FindItemWithName method. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/b47a29dc541a8cefda7c14274581e9c868944400
Bug 1562292: Part 2c - Use BrowserContext rather than DocShell to resolve named targets. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/8303383dd95b60e0b23d961bc397f670b2fd0383
Bug 1562292: Part 2d - Operate on BrowsingContext in most of OpenWindowInternal. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/de2caa18324b6dab0f75b760e3abdaa96bc381cd
Bug 1562292: Part 3 - Update test annotations. r=nika

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fae715f6c26e75f825c7c6cbd694d19522ebf27
Bug 1562292: Follow-up: Fix bustage in GetWindowByName after dropping removal patch. r=bustage CLOSED TREE

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d513683e1fdb
https://hg.mozilla.org/mozilla-central/rev/f1fc2382346d
https://hg.mozilla.org/mozilla-central/rev/a8ac7bcafc27
https://hg.mozilla.org/mozilla-central/rev/a50f085eb3e6
https://hg.mozilla.org/mozilla-central/rev/ba987e21b532
https://hg.mozilla.org/mozilla-central/rev/3bffe760e2db
https://hg.mozilla.org/mozilla-central/rev/40b61344f0da
https://hg.mozilla.org/mozilla-central/rev/ce60426d7e31
https://hg.mozilla.org/mozilla-central/rev/b47a29dc541a
https://hg.mozilla.org/mozilla-central/rev/8303383dd95b
https://hg.mozilla.org/mozilla-central/rev/de2caa18324b
https://hg.mozilla.org/mozilla-central/rev/0fae715f6c26