1562301 - GeckoView Example app does not support viewing images

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Botond Ballo [:botond]]

STR

1. Load https://ai.googleblog.com/2019/05/moving-camera-moving-people-deep.html?m=1 in GVE
2. Scroll down to an image
3. Tap on the image

Expected results

The browser displays only the image.

Actual results

Nothing happens.

This is preventing me from finding a regression range for this webcompat issue because I cannot perform the STR in GVE.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Looks like we have problems with _blank links. The tab actually opens but clicking on it doesn't do anything, also the tab counter doesn't increase.

Comment 2

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #0)

This is preventing me from finding a regression range for this webcompat issue because I cannot perform the STR in GVE.

(I'm not actually blocked on this any more, as I found alternate STR that don't involve viewing an image. However, it would still be nice if this worked.)

Comment 3

[Chris Peterson [:cpeterson]]

Botond, can you still repro this image loading problem? James says he recently fixed a similar tab opening bug.

Comment 4

[Botond Ballo [:botond]]

I can still repro it. The results changed somewhat: I now see a flicker of an increasing count (tab count?) in the address bar, suggesting that we perhaps try to open the image in a new tab? I don't see any way to get to such a new tab though.

Comment 5

[Chris Peterson [:cpeterson]]

Dylan says we are opening the tab, but GVE is hiding the tabs button if the URL is too long.

Emily will investigate.

Comment 6

[Emily Toop (:fluffyemily)]

Attachment: Bug 1562301: Stop URL bar hiding tab switcher in GVE.

The URL bar was expanding to cover the tab switcher button, meaning that a new tab could not be navigated to after opening.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa7e431e2e2a
Stop URL bar hiding tab switcher in GVE. r=geckoview-reviewers,agi

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/aa7e431e2e2a

Comment 9

[Chris Peterson [:cpeterson]]

firefox69=wontfix because we don't need to uplift a GVE fix to Beta.