1562312 - implement contain:size for `<select multiple>` elements

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Daniel Holbert [:dholbert]]

Testcase:
data:text/html,<select multiple style="contain:size"></select><br><select multiple style="contain:size"><option>aaaaaaaaaaaaaaaaa

STR: Load that ^ testcase.

EXPECTED RESULTS: The two elements should size the same.
ACTUAL RESULTS: The second one is wider.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1562312: Implement 'contain:size' for <select multiple> elements. r?TYLin

Comment 2

[Daniel Holbert [:dholbert]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=41a1b6d4bfefb3521a1400bcaf285c46ff995219

Comment 3

[Daniel Holbert [:dholbert]]

The try run shows failures on Android, and that's because on Android we apparently compute the BSize of <select multiple> elements differently, depending on whether it has any options or not. (whereas on other platforms, we seem to mostly compute them the same)

I filed bug 1562556 on that, and I'll annotate the Android test failures as expected-fail due to that bug.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Current patch isn't quite done -- the last two elements in this testcase (with a large font on the <option> children) are still taller than the rest with the attached patch, despite the select having contain:size.

(Chrome actually fails in this case, too. I'll file a bug on them.)

Comment 5

[Daniel Holbert [:dholbert]]

OK, I just posted an update that makes us do the right thing on "testcase 1" from comment 4 here (sizing all the boxes the same).

Still need to post automated tests for that part, but hopefully this is code-complete now.

Comment 6

[Daniel Holbert [:dholbert]]

ni=tylin since I've added a new testcase to the patch which probably needs a quick check, and I can't re-request review on phab. Thanks!

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Re-review done. Thanks!

Comment 8

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #3)

The try run shows failures on Android, and that's because on Android we apparently compute the BSize of <select multiple> elements differently, depending on whether it has any options or not. [...] I filed bug 1562556 on that

This bsize issue doesn't make these tests fail on android anymore, as of the bsize-suppression changes referenced in comment 5.

Here's a final (I hope) Try run to verify that the tests pass on Android:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d018aeb63b38da4dc1dfe087a5cba8c0fdc9e3d0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a248baf99301
Implement 'contain:size' for <select multiple> elements. r=TYLin

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a248baf99301

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

WPT import: https://github.com/web-platform-tests/wpt/pull/17628