1562427 - Can we revert bug 1540984 now?

Status: VERIFIED FIXED

(WebExtensions :: Themes, task)

Description

[Emilio Cobos Álvarez (:emilio)]

AFAICT, even though the underlying issue is still not fixed, bug 1554405 should have fixed it too, right?

Can we stop using -moz-element now?

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

If you want to test some Firefox try-build, just needinfo me, I will glad to help.

Comment 2

[Kris Maglione [:kmag]]

If reverting it doesn't trigger flickering when opening or focusing windows with themes with large background images, sure.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Ok, I'll prepare a build so Virtual can test it (probably Monday material though). Thanks both!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Virtual, mind giving this build a spin?

Thank you!

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: screencast.mp4

I done STR from bug #1540984 comment #21 and I can't reproduce that issue with this build ( https://treeherder.mozilla.org/#/jobs?repo=try&revision=a057db5eb2bd9682ae7c94f86cb0fb36050d9203 - I tested "Windows 2012 x64 shippable opt" one ). So green light from me. Thank you very much! \o/

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1562427 - Back out bug 1540984, since bug 1554405 fixes it in a way that doesn't need -moz-element(). r=kmag

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b3cf4a82ce4
Back out bug 1540984, since bug 1554405 fixes it in a way that doesn't need -moz-element(). r=kmag

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Thanks for testing Virtual!

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5b3cf4a82ce4

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #8)

Thanks for testing Virtual!

My pleasure!

I also confirming that bug is fixed, starting in Mozilla Firefox Nightly 69.0a1 (2019-07-04), so I'm marking this bug as VERIFIED.
Thank you very much one more time! \o/