Closed Bug 1562606 Opened 4 months ago Closed 4 months ago

Implement unsigned LEB128 read/write function over an iterator

Categories

(Core :: Gecko Profiler, task, P2)

Product:
Core
Component:
Gecko Profiler
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

Bug 1562606 - Implement unsigned LEB128 functions working over iterators - r?gregtatum
47 bytes, text/x-phabricator-request
Details | Review

We have a few other LEB128 routines around the place, but for my work on the new ProfileBuffer I need functions that can write to, or read from, an iterator.
(This iterator will hide the wrapping happening in the ProfileBuffer circular buffer.)

And the LEB128 numbers will be primarily used to store sizes of usually-small data blocks, which is where LEB128 helps by using less memory for small numbers.

The new ProfileBuffer data structure will need to store block sizes (usually
small, LEB128 uses fewer bytes for small numbers), and the circular buffer will
provide iterators that hide the wrapping-around.

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41fb123dc560
Implement unsigned LEB128 functions working over iterators - r=gregtatum
Blocks: 1563425

https://hg.mozilla.org/mozilla-central/rev/41fb123dc560

Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox69: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.