1562640 - 20.06 - 72.49% raptor-tp6m-instagram-geckoview-cold (android-hw-g5-7-0-arm7-api-16, android-hw-p2-8-0-android-aarch64, android-hw-p2-8-0-arm7-api-16) regression on push d7be4e6bb7f108cca7e643fdb47ffad1bded1775 (Wed June 26 2019)

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, defect)

Description

[Florin Strugariu [:Bebe]]

Raptor has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=d7be4e6bb7f108cca7e643fdb47ffad1bded1775

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

72% raptor-tp6m-instagram-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 pgo 214.17 -> 369.42
71% raptor-tp6m-instagram-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 pgo 217.08 -> 372.17
66% raptor-tp6m-instagram-geckoview-cold fcp android-hw-p2-8-0-arm7-api-16 opt 229.92 -> 382.25
59% raptor-tp6m-instagram-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 opt 233.33 -> 369.92
50% raptor-tp6m-instagram-geckoview-cold android-hw-p2-8-0-android-aarch64 pgo 404.30 -> 607.08
46% raptor-tp6m-instagram-geckoview-cold android-hw-p2-8-0-arm7-api-16 opt 428.93 -> 624.16
39% raptor-tp6m-instagram-geckoview-cold android-hw-p2-8-0-android-aarch64 opt 438.35 -> 608.89
28% raptor-tp6m-instagram-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 467.79 -> 600.50
28% raptor-tp6m-instagram-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 opt 484.08 -> 619.83
21% raptor-tp6m-instagram-geckoview-cold android-hw-g5-7-0-arm7-api-16 pgo 805.91 -> 973.89
20% raptor-tp6m-instagram-geckoview-cold android-hw-g5-7-0-arm7-api-16 opt 841.01 -> 1,009.76

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21690

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.

To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/Performance_sheriffing/Raptor

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Kelsey Gilbert [:jgilbert]]

This looks like a return to baseline:
https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=mozilla-central,2008820,1,10

Originally, bug 1559524 landed 2019-06-15, but introduced behavioral regressions which bug 1559681 repaired.
By repairing the behavioral regressions, we returned to our pre-2019-06-15 baseline.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Marking this INVALID (not a bug). Up to Sotaro if they want to investigate the potential for perf improvements while retaining correctness.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Specifically, this is "not a regression" from any previously-good state.

Comment 4

[Sotaro Ikeda [:sotaro]]

Hmm, it is strange. bug 1559681 should affect only to Windows10. The changed code is not used on android.