Open Bug 1562642 Opened 5 months ago Updated 5 days ago

Add missing MPL license headers

Categories

(Firefox Build System :: Source Code Analysis, defect, P3)

defect

Tracking

(firefox69 affected)

Tracking Status
firefox69 --- affected

People

(Reporter: Gijs, Assigned: Sylvestre)

References

(Regression)

Details

(Keywords: leave-open)

Attachments

(26 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

See summary.

Looks like all the .cpp/.h files in dom/l10n/ have no license info? :-\

Assignee: nobody → sledru
Summary: DOMLocalization.cpp and DOMLocalization.h (and maybe others) need MPL license headers → Add missing MPL license headers
Component: Internationalization → Source Code Analysis
Product: Core → Firefox Build System

Others will follow

Keywords: leave-open
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4b135906080
Add missing MPL2 headers r=mhoye
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92abb79e4d43
Fix build bustages. r=bustage-fix
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50d73bfcb2a1
Part 2 - Add missing MPL2 headers r=Gijs
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/6f0b76b08f38
Part 2 - Add missing MPL2 headers: Remove undesired ~. a=bustage-fix
Attachment #9076477 - Attachment description: Bug 1562642 - Part 3 - Add missing MPL2 headers r?mhoye,gijs → Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r?mhoye,gijs
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fae198b4ea3d
Add toolkit/components/utils/mozjexl.js to the list of thirdparty code r=Gijs
Depends on: 1564437
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/74bd7d9f0276
Ride along: Add normandy/vendor/ and raven to the list of thirdparty code r=Gijs
Attachment #9076477 - Attachment description: Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r?mhoye,gijs → Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r?gijs
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7db3bf599bf8
Ride along: Add newtab/vendor/ to the list of thirdparty code r=Gijs
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d59cb02b6ff
Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs

[task 2019-07-10T11:38:14.240Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/newtab/bin/vendor.js:6:1 | Delete?(prettier/prettier)

We should have prettier at review phase. See bug 1564854

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ca2b17dd7f3
Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24f264c75fcd
Part 4 - Add missing MPL2 headers in tools r=ahal
See Also: → 1565088

The priority flag is not set for this bug.
:sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79659ba6c21a
Part 4 - Add missing MPL2 headers in js/ r=jorendorff
Flags: needinfo?(sledru)
Priority: -- → P3

What's left to do here? :-)

Flags: needinfo?(sledru)

Oh, a bunch of directories :)
And starting doing on tests (will take a bunch of time).

I was on pto, I will have a look to fix other directories (or create good first bugs)

Flags: needinfo?(sledru)

We still have a few license issues:
✖ 12603 problems (12603 errors, 0 warnings)

Actually, looks a bit less (it was analyzing node_modules/ and some other temp directories):
just an hundred

Ride along: also add node_modules/ (generated by moz lint)

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18f25e769620
Add some devtools dirs to the list of thirdparty code r=jlast
https://hg.mozilla.org/integration/autoland/rev/f97a73ccdb19
Part 5 - Add missing MPL2 headers in devtools/ r=jlast
See Also: → 1570772
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9c7b66ccddb
Cleanup the js exclude list + add a new string in the list of valid license r=andi
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bd5020154a1
add missing license in xpcom/ r=froydnj
https://hg.mozilla.org/integration/autoland/rev/2d63fadd766d
add missing license in taskcluster r=dustin
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79b526e185ec
add missing license in gfx/ r=nical
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd37ff69e786
add missing license in media/webrtc/signaling/src/sdp/ r=drno
https://hg.mozilla.org/integration/autoland/rev/c3a542c1d608
add acorn to the list of thirdparty code r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/051318d05eb0
add missing license in dom/manifest r=sebastian
https://hg.mozilla.org/integration/autoland/rev/d3ddff85e5e9
add missing license in docshell/resources/content/netError.js r=smaug
https://hg.mozilla.org/integration/autoland/rev/291e0963223b
add missing license in netwerk/base/rust-helper/src/lib.rs r=valentin
https://hg.mozilla.org/integration/autoland/rev/0ec55dcb63d9
add missing license in python/l10n/convert_xul_to_fluent r=zbraniecki
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96695741c87a
add missing license in layout/style/tools/ r=emilio
https://hg.mozilla.org/integration/autoland/rev/8001d4ae9b00
Add some pocket code in the thirdparty code list r=Gijs
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/509f74c50ad9
add missing license in python/mozrelease/mozrelease r=catlee
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d715026b6398
license.yml: refresh the list of excludes r=ahal
You need to log in before you can comment on or make changes to this bug.