1562642 - Add missing MPL license headers for the code

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Description

[:Gijs (he/him)]

See summary.

Comment 1

[:Gijs (he/him)]

Looks like all the .cpp/.h files in dom/l10n/ have no license info? :-\

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Add missing MPL2 headers r?mhoye

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Others will follow

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4b135906080
Add missing MPL2 headers r=mhoye

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92abb79e4d43
Fix build bustages. r=bustage-fix

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e4b135906080
https://hg.mozilla.org/mozilla-central/rev/92abb79e4d43

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Part 2 - Add missing MPL2 headers r?mhoye

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r?gijs

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50d73bfcb2a1
Part 2 - Add missing MPL2 headers r=Gijs

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0b76b08f38
Part 2 - Add missing MPL2 headers: Remove undesired ~. a=bustage-fix

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Add toolkit/components/utils/mozjexl.js to the list of thirdparty code r?gijs

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fae198b4ea3d
Add toolkit/components/utils/mozjexl.js to the list of thirdparty code r=Gijs

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/50d73bfcb2a1
https://hg.mozilla.org/mozilla-central/rev/6f0b76b08f38
https://hg.mozilla.org/mozilla-central/rev/fae198b4ea3d

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Ride along: Add normandy/vendor/ and raven to the list of thirdparty code r?gijs

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74bd7d9f0276
Ride along: Add normandy/vendor/ and raven to the list of thirdparty code r=Gijs

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Ride along: Add newtab/vendor/ to the list of thirdparty code r?gijs

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7db3bf599bf8
Ride along: Add newtab/vendor/ to the list of thirdparty code r=Gijs

Comment 18

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/74bd7d9f0276

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d59cb02b6ff
Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs

Comment 20

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Part 4 - Add missing MPL2 headers in js/ r?jorendorff

Comment 21

[Andreea Pavel [:apavel]]

Backed out for eslint failure

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=3d59cb02b6ff3ad4d51636346076e4a0123acec3&selectedJob=255693088

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255693088&repo=autoland&lineNumber=76

Backout: https://hg.mozilla.org/integration/autoland/rev/b4c30f60f7a17277de6c7edaf830b5389506690c

Comment 22

[Sylvestre Ledru [:Sylvestre]]

[task 2019-07-10T11:38:14.240Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/newtab/bin/vendor.js:6:1 | Delete?(prettier/prettier)

We should have prettier at review phase. See bug 1564854

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ca2b17dd7f3
Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs

Comment 24

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Part 4 - Add missing MPL2 headers in tools r?ahal

Comment 25

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7db3bf599bf8

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24f264c75fcd
Part 4 - Add missing MPL2 headers in tools r=ahal

Comment 27

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1ca2b17dd7f3

Comment 28

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/24f264c75fcd

Comment 29

[Sylvestre Ledru [:Sylvestre]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7441f17df0a9172e0bdd8673b7c88db1a6c12af5

Comment 30

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79659ba6c21a
Part 4 - Add missing MPL2 headers in js/ r=jorendorff

Comment 32

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/79659ba6c21a

Comment 33

[:Gijs (he/him)]

What's left to do here? :-)

Comment 34

[Sylvestre Ledru [:Sylvestre]]

Oh, a bunch of directories :)
And starting doing on tests (will take a bunch of time).

I was on pto, I will have a look to fix other directories (or create good first bugs)

Comment 35

[Sylvestre Ledru [:Sylvestre]]

We still have a few license issues:
✖ 12603 problems (12603 errors, 0 warnings)

Comment 36

[Sylvestre Ledru [:Sylvestre]]

Actually, looks a bit less (it was analyzing node_modules/ and some other temp directories):
just an hundred

Comment 37

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Add some devtools dirs to the list of thirdparty code r?jlast

Ride along: also add node_modules/ (generated by moz lint)

Comment 38

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Part 5 - Add missing MPL2 headers in devtools/ r=jlast

Depends on D41566

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18f25e769620
Add some devtools dirs to the list of thirdparty code r=jlast
https://hg.mozilla.org/integration/autoland/rev/f97a73ccdb19
Part 5 - Add missing MPL2 headers in devtools/ r=jlast

Comment 40

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Add a missing license r?andi

Comment 41

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Part 6 - Add missing MPL2 headers in python/ r?ahal

Depends on D41714

Comment 42

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/18f25e769620
https://hg.mozilla.org/mozilla-central/rev/f97a73ccdb19

Comment 43

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Cleanup the js exclude list + add a new string in the list of valid license r?andi

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9c7b66ccddb
Cleanup the js exclude list + add a new string in the list of valid license r=andi

Comment 45

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a9c7b66ccddb

Comment 46

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in xpcom/ r?froydnj

Comment 47

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in taskcluster r?dustin

Depends on D52579

Comment 48

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in gfx/ r?nical

Depends on D52581

Comment 49

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in media/webrtc/signaling/src/sdp/ r?drno

Depends on D52582

Comment 50

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add acorn to the list of thirdparty code r?nchevobbe

Depends on D52583

Comment 51

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in dom/manifest r?sebastian

Depends on D52585

Comment 52

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in docshell/resources/content/netError.js r?smaug

Depends on D52588

Comment 53

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in netwerk/base/rust-helper/src/lib.rs r?valentin

Depends on D52589

Comment 54

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in python/l10n/convert_xul_to_fluent r?flod

Depends on D52590

Comment 55

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in python/mozrelease/mozrelease r?tomprince

Depends on D52591

Comment 56

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - add missing license in layout/style/tools/ r?emilio

Depends on D52592

Comment 57

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Add some pocket code in the thirdparty code list r?Gijs

Depends on D52593

Comment 58

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - license.yml: refresh the list of excludes r?ahal

Depends on D52594

Comment 59

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bd5020154a1
add missing license in xpcom/ r=froydnj
https://hg.mozilla.org/integration/autoland/rev/2d63fadd766d
add missing license in taskcluster r=dustin

Comment 60

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5bd5020154a1
https://hg.mozilla.org/mozilla-central/rev/2d63fadd766d

Comment 61

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79b526e185ec
add missing license in gfx/ r=nical

Comment 62

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd37ff69e786
add missing license in media/webrtc/signaling/src/sdp/ r=drno
https://hg.mozilla.org/integration/autoland/rev/c3a542c1d608
add acorn to the list of thirdparty code r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/051318d05eb0
add missing license in dom/manifest r=sebastian
https://hg.mozilla.org/integration/autoland/rev/d3ddff85e5e9
add missing license in docshell/resources/content/netError.js r=smaug
https://hg.mozilla.org/integration/autoland/rev/291e0963223b
add missing license in netwerk/base/rust-helper/src/lib.rs r=valentin
https://hg.mozilla.org/integration/autoland/rev/0ec55dcb63d9
add missing license in python/l10n/convert_xul_to_fluent r=zbraniecki

Comment 63

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96695741c87a
add missing license in layout/style/tools/ r=emilio
https://hg.mozilla.org/integration/autoland/rev/8001d4ae9b00
Add some pocket code in the thirdparty code list r=Gijs

Comment 64

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/79b526e185ec

Comment 65

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/cd37ff69e786
https://hg.mozilla.org/mozilla-central/rev/c3a542c1d608
https://hg.mozilla.org/mozilla-central/rev/051318d05eb0
https://hg.mozilla.org/mozilla-central/rev/d3ddff85e5e9
https://hg.mozilla.org/mozilla-central/rev/291e0963223b
https://hg.mozilla.org/mozilla-central/rev/0ec55dcb63d9
https://hg.mozilla.org/mozilla-central/rev/96695741c87a
https://hg.mozilla.org/mozilla-central/rev/8001d4ae9b00

Comment 66

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/509f74c50ad9
add missing license in python/mozrelease/mozrelease r=catlee

Comment 67

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d715026b6398
license.yml: refresh the list of excludes r=ahal

Comment 68

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/509f74c50ad9

Comment 69

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/d715026b6398

Comment 70

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:Sylvestre, maybe it's time to close this bug?

Comment 71

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - Add missing license headers r?gijs,mhoye

Depends on D97136

Comment 72

[Sylvestre Ledru [:Sylvestre]]

Working on something else, I noticed that we were missing /testing/
so, not ready to close it

Comment 73

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - mozlint/license: Unify some license pattern r?tarek,gijs

Depends on D97138

Comment 74

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93ed59e1609f
mozlint/license: Unify some license pattern r=tarek DONTBUILD

Comment 75

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1562642 - mozlint/license: Simplify the MIT license detection r?mhoye

Depends on D97138

Comment 76

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1affabd8110
Add missing license headers r=mhoye,marionette-reviewers,webdriver-reviewers,perftest-reviewers,tarek
https://hg.mozilla.org/integration/autoland/rev/2a10175a1002
mozlint/license: Simplify the MIT license detection r=mhoye

Comment 77

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/93ed59e1609f
https://hg.mozilla.org/mozilla-central/rev/a1affabd8110
https://hg.mozilla.org/mozilla-central/rev/2a10175a1002

Comment 78

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:Sylvestre, maybe it's time to close this bug?

Comment 79

[Sylvestre Ledru [:Sylvestre]]

yes autonag, we still need to work on that for tests ...
but I will create a separate bug for this

Comment 80

[Sylvestre Ledru [:Sylvestre]]

bug 1713577 for the test work.
I think we are good for the code itself
the exclude list is reasonable:
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/tools/lint/license.yml#6