1562680 - Implement the new syntax (= {}) for dictionary defaulting

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

See https://github.com/heycam/webidl/pull/750

This implements two things:

1. A syntax for specifying "default dictionary" using {}.
2. The requirement that trailing optional dictionaries be thus specified.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv

= {} can now be used to indicate that an optional dictionary should have the
default value of 'default-initialized dictionary'

Comment 2

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12653dd76667
Implement the new syntax for Web IDL dictionary defaulting.  r=peterv

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 12653dd76667 for causing bustages in FuzzingFunctions.webidl

Backout link: https://hg.mozilla.org/integration/autoland/rev/ea1bdf131082f9a8a2fd96282f70896632e62a58

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=12653dd76667080596c6d71f01d4bc6457bb4527&searchStr=build&selectedJob=254552202

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254552202&repo=autoland&lineNumber=3699

[task 2019-07-03T06:38:43.296Z] 06:38:43 INFO - WebIDL.WebIDLError: error: Dictionary argument without any required fields or union argument containing such dictionary not followed by a required argument must have a default value, /builds/worker/workspace/build/src/dom/webidl/FuzzingFunctions.webidl line 111:66
[task 2019-07-03T06:38:43.296Z] 06:38:43 INFO - optional KeyboardEventInit aDictionary);
[task 2019-07-03T06:38:43.296Z] 06:38:43 INFO - ^
[task 2019-07-03T06:38:43.296Z] 06:38:43 INFO - Makefile:55: recipe for target 'webidl.stub' failed
[task 2019-07-03T06:38:43.296Z] 06:38:43 ERROR - make[4]: *** [webidl.stub] Error 1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e16f13a88c8
Implement the new syntax for Web IDL dictionary defaulting.  r=peterv

Comment 6

[Boris Zbarsky [:bzbarsky]]

Looks like the fuzzing builds include the extra FuzzingFunctions file that nothing else builds...

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6430800a95e1
Backed out changeset 8e16f13a88c8 for colliding with Bug 1366738 that was backed out. CLOSED TREE

Comment 8

[Cosmin Sabou [:CosminS]]

Because the changes here relied on what changed with Bug 1366738 and that one was backed out because of mochitest failures by https://hg.mozilla.org/integration/autoland/rev/a70f62521b875857e709f4120006ac2429c869c2 we had build bustages on that backout https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=a70f62521b875857e709f4120006ac2429c869c2&selectedJob=254556814
So in order to have green builds again I also backed out this bug: https://hg.mozilla.org/integration/autoland/rev/6430800a95e1d2101859af8145ed1353c6cf79c9
Somehow when backing out Bug 1366738 we didn't have hunked fail and that's why we went on with the initial backout.
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=a70f62521b875857e709f4120006ac2429c869c2&selectedJob=254556814

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254556814&repo=autoland&lineNumber=3497

Backout link: https://hg.mozilla.org/integration/autoland/rev/6430800a95e1d2101859af8145ed1353c6cf79c9
Boris, sorry, it just looks like a case of bad timing.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Somehow when backing out Bug 1366738 we didn't have hunked fail

That's because that bug removed some code that this bug would have needed to change had that code still been around.

That said, looks like bug 1366738 has been re-landed, so this should just re-land too.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59c08b215af5
Implement the new syntax for Web IDL dictionary defaulting.  r=peterv

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/59c08b215af5