Closed Bug 1562725 Opened 7 months ago Closed 7 months ago

Fix log artifacts for Linux PGO runs

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox68 unaffected, firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1557785 changed how UPLOAD_PATH was set in run-profileserver.sh, which caused it to no longer be exported in Linux PGO runs. This broke uploading the logs from the Firefox process (eg: profile-run-1.log). Instead the log just goes to stdout.

When adding Windows compatibility in bug 1557785, we stopped exported
UPLOAD_PATH by default. UPLOAD_PATH is used by profileserver.py to
determine where to store the logs; when it is unset, the logs go to
stdout and the artifacts aren't created. We should always export
UPLOAD_PATH to get the same logging behavior on all platforms.

Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9bc355a1aea3
export UPLOAD_PATH in run-profileserver.sh; r=firefox-build-system-reviewers,chmanchester
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.