1562750 - GUI for adding language packs is broken

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

When you toggle the pref intl.multilingual.enabled to true (and probably also the pref intl.multilingual.downloadEnabled), you get a Languages box in ToolS > Options > Advanced > General. When you click on the language and select "Search for more languages…", a popup window appears, where you should be able to add more languages.
This window is broken however, and displays an error message:
{ -brand-short-name } can't update your languages right now. Check that you are connected to the internet or try again.
There should also be an icon displayed in front of the message, but that icon <chrome://browser/skin/identity-icon.svg> isn't included inThundernbird.

In order for the window to work, the pref extensions.getAddons.langpacks.url should be added to Thunderbird, pointing to https://services.addons.thunderbird.net/api/v3/addons/language-tools/?app=thunderbird&type=language&appversion=68

And then of course also the build process should work again so that the language packs on addons.thunderbird.net get updated again.

See here where the pref is used: https://searchfox.org/comm-central/source/mozilla/toolkit/mozapps/extensions/internal/AddonRepository.jsm#785

Comment 1

[Jorg K (GMT+2)]

Richard, this is meant to be disabled. How come it's suddenly enabled again?

Comment 2

[Richard Marti (:Paenglab)]

It's not suddenly enabled. Onno wrote, he enabled intl.multilingual.downloadEnabled. The download isn't enabled in TB because ATN has no actual language packs on its site and the upload of this packages isn't automatically done. So this is invalid or we need to look that Rob looks for the upload and Andrei implements the website needs. There should be a bug for this but I'm at work and can't search for it.

And about the icon: This comes from https://searchfox.org/comm-central/source/mozilla/toolkit/themes/shared/in-content/common.inc.css#920. Again they point from a toolkit file to a browser resource.

Comment 3

[Onno Ekker [:nONoNonO UTC+1]]

(In reply to Richard Marti (:Paenglab) from comment #2)

And about the icon: This comes from https://searchfox.org/comm-central/source/mozilla/toolkit/themes/shared/in-content/common.inc.css#920. Again they point from a toolkit file to a browser resource.

Should I clone this bug for the icon issue to toolkit?

Comment 4

[Richard Marti (:Paenglab)]

You can, and CC me please.

Comment 5

[Onno Ekker [:nONoNonO UTC+1]]

Regardless of the issue with the icon and the issue with the language packs themselves not being available on ATB, I think the pref extensions.getAddons.langpacks.url should be added to Thunderbird...

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: Bug 1562750 - Add missing pref to thunderbird profile

Add missing pref to Thunderbird profile, so language pack install can work,
once they become available on addons.thunderbird.net.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9077717 [details]
Bug 1562750 - Add missing pref to thunderbird profile

Onno, no need to use Phabricator for C-C. Andrei seems to have no account. And I think, it's better he checks the URL because he's the server guy.

Andrei, the pref would be this:

pref("extensions.getAddons.langpacks.url", "https://services.addons.thunderbird.net/api/v3/addons/language-tools/?app=thunderbird&type=language&appversion=%VERSION%");

Would this be the correct URL?

Comment 8

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 9077717 [details]
Bug 1562750 - Add missing pref to thunderbird profile

Yeah, that URL looks correct to me, and also seems to work as expected: https://services.addons.thunderbird.net/api/v3/addons/language-tools/?app=thunderbird&type=language&appversion=60.8.0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/305c070b0794
Add pref for language pack install. r=sancus DONTBUILD

Comment 10

[Jorg K (GMT+2)]

Please request uplifts as you deem fit.

Comment 11

[Onno Ekker [:nONoNonO UTC+1]]

Comment on attachment 9077717 [details]
Bug 1562750 - Add missing pref to thunderbird profile

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 12

[Jorg K (GMT+2)]

Comment on attachment 9077717 [details]
Bug 1562750 - Add missing pref to thunderbird profile

OK, stuff will find its way to ESR via the beta. But it all doesn't help if ATN isn't up to it yet.

Comment 13

[Jorg K (GMT+2)]

TB 68 beta 5:
https://hg.mozilla.org/releases/comm-beta/rev/e6763c25c04949deb0dbc895c1b9edb28b4b741e

TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/093a473a56de757942b12b3df9386d358aff11c6