Closed Bug 1562847 Opened 5 years ago Closed 5 years ago

Disable double buffering when device reset happens

Categories

(Core :: Graphics: Layers, enhancement)

Product:
Core
Component:
Graphics: Layers
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1562847 - Disable double buffering with compositor when device reset happens
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 1562847 for beta - Disable double buffering with compositor when device reset happens
7.27 KB, patch
Details | Diff | Splinter Review

Created by Bug 1555098 comment 23.

Assignee: nobody → sotaro.ikeda.g
See Also: → 1555082
Attachment #9075334 - Attachment description: Bug 1562847 - Disable double buffering when device reset happens → Bug 1562847 - Disable double buffering with compositor when device reset happens
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88adbf9955ce
Disable double buffering with compositor when device reset happens r=nical,bas
Blocks: 1555082

https://hg.mozilla.org/mozilla-central/rev/88adbf9955ce

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

This seems like something we probably want to uplift to 69 right Sotaro?

Flags: needinfo?(sotaro.ikeda.g)

Comment on attachment 9075334 [details]
Bug 1562847 - Disable double buffering with compositor when device reset happens

Beta/Release Uplift Approval Request

  • User impact if declined: There is a device that double buffering usage causes continuous device resets. The device resets happens until Firefox fallback to BasicCompositor(software)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change is simple. It disables double buffering when device reset happen.
  • String changes made/needed: none
Flags: needinfo?(sotaro.ikeda.g)
Attachment #9075334 - Flags: approval-mozilla-beta?
See Also: → 1568736

Comment on attachment 9075334 [details]
Bug 1562847 - Disable double buffering with compositor when device reset happens

Disables double buffering after hitting a device reset to avoid a continuous series of them. Approved for 69.0b8.

Attachment #9075334 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(sotaro.ikeda.g)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: