Read update data at startup, but don't use the data
Categories
(Toolkit :: Safe Browsing, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: dimi, Assigned: dimi)
References
Details
Attachments
(1 file)
Listmanager calls getTables at startup[1] and then read files to obtain on-disk information[2], but we don't really use the data[3].
We can skip reading on-disk data if it is not necessary
[1] https://searchfox.org/mozilla-central/rev/8a990595ce6d5ed07ace2d4d5d86cc69aec90bde/toolkit/components/url-classifier/UrlClassifierListManager.jsm#328
[2] https://searchfox.org/mozilla-central/rev/8a990595ce6d5ed07ace2d4d5d86cc69aec90bde/toolkit/components/url-classifier/Classifier.cpp#404
[3] https://searchfox.org/mozilla-central/rev/8a990595ce6d5ed07ace2d4d5d86cc69aec90bde/toolkit/components/url-classifier/UrlClassifierListManager.jsm#263
|
Assignee | |
Comment 1•5 years ago
|
||
Just some note, the on-disk data were used before Bug 1045163, then the bug removed it
|
|
Assignee | |
Comment 2•5 years ago
|
||
While listmanager called |kickoffUpdate|, it used to call |GetTables| to
retrieve update information and used the information to distinguish if
a table is a "existing" table or not.
In Bug 1045163, the "existing table" logic was removed, which also means we
don't need to call |GetTabkes| anymore. This patch removes calling
Classifier::TableRequest to reduce unnecessary disk IO during startup.
|
||
Comment 3•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:dimi, could you have a look please?
For more information, please visit auto_nag documentation.
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3174ab6c79af Listmanager kiffoffUpdate doesn't need to obtain on-disk data. r=gcp
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•