1562997 - Use HTML input instead of XUL textbox in calendar-task-view.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

https://searchfox.org/comm-central/rev/94d2c771f935e9402ca3d19a43fafeeaa8f0ac4f/calendar/base/content/calendar-task-view.xul#38

Do not replace <textbox is="search-textbox"> as this will most likely need to be converted into a CE.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1562997-textbox-html-input.patch

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: 1562997-textbox-html-input.patch

Some JS fixes I missed in the previous patch.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: 1562997-textbox-html-input.patch

Sorry, another small update to remove all the textbox reference in the comments.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9084371 [details] [diff] [review]
1562997-textbox-html-input.patch

Review of attachment 9084371 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright to me

Comment 5

[Alessandro Castellani [:aleca]]

I did a try run for all the textboxes I'm converting: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=05df15d2b65905a9f8611d2b6c6c465fc0f3ed50

Comment 6

[Jorg K (CEST = GMT+2)]

Umm, why do we do try runs if we don't look at them :-(
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1565639857/build/tests/mozmill/views/testTaskView.js | testTaskView.js::testTaskView

Comment 7

[Alessandro Castellani [:aleca]]

Attachment: 1562997-textbox-html-input.patch

Patch updated.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2ba6abed2358dd28b1be2ec16cf0d3ac972baddc

Those Z2 and X2 pass locally, is it normal?

Comment 8

[Jorg K (CEST = GMT+2)]

Sadly these three are intermittent, X2 test_nsDefaultURIFixup_info.js is and M-C test, testAlarmDialog.js seems to be failing a lot lately, I need to file a bug, and test-selection.js is bug 1568789 :-( - We can check it in now.
EDIT: Filed bug 1573382 for testAlarmDialog.js.

Comment 9

[Jorg K (CEST = GMT+2)]

Please check your patched before submitting them in order not to have this happen: \ No newline at end of file

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b7eaf68c3a37
textbox to html input in calendar-task-view.xul. r=mkmelin