1563009 - Use HTML input instead of XUL textbox in chat/content

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

• otr-add-fingerprint.xul
• otr-auth.xul

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1563009_textbox_chat.patch

Changed the 1 row textareas too, looks nicer now.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1563009_textbox_chat.patch

Converted the 1 row textareas too, looks nicer now

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9095427 [details] [diff] [review]
bug1563009_textbox_chat.patch

Review of attachment 9095427 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you so much for taking care of this, and yes, the textareas look way better.

Just a nit related to the missing aria labels for the converted inputs, if you think are necessary.

r=aleca

::: chat/content/otr-auth.xul
@@ +42,3 @@
>      <description style="width: 300px; white-space: pre-wrap;" data-l10n-id="auth-qaInstruction"></description>
> +    <label data-l10n-id="auth-question" control="question" flex="1"/>
> +    <html:input id="question" type="text" class="input-inline" />

I think we should add the aria-labelledby attribute since the label control doesn't automatically apply the text for accessibility.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1563009_textbox_chat.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8bafe0778749
Use HTML input instead of XUL textbox in chat/content. r=aleca