Closed Bug 1563009 Opened 8 months ago Closed 5 months ago

Use HTML input instead of XUL textbox in chat/content

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: aleca, Assigned: mkmelin, Mentored)

References

Details

Attachments

(1 file, 2 obsolete files)

  • otr-add-fingerprint.xul
  • otr-auth.xul
Attached patch bug1563009_textbox_chat.patch (obsolete) — Splinter Review

Changed the 1 row textareas too, looks nicer now.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9095426 - Flags: review?(alessandro)
Attached patch bug1563009_textbox_chat.patch (obsolete) — Splinter Review

Converted the 1 row textareas too, looks nicer now

Attachment #9095426 - Attachment is obsolete: true
Attachment #9095426 - Flags: review?(alessandro)
Attachment #9095427 - Flags: review?(alessandro)
Comment on attachment 9095427 [details] [diff] [review]
bug1563009_textbox_chat.patch

Review of attachment 9095427 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you so much for taking care of this, and yes, the textareas look way better.

Just a nit related to the missing aria labels for the converted inputs, if you think are necessary.

r=aleca

::: chat/content/otr-auth.xul
@@ +42,3 @@
>      <description style="width: 300px; white-space: pre-wrap;" data-l10n-id="auth-qaInstruction"></description>
> +    <label data-l10n-id="auth-question" control="question" flex="1"/>
> +    <html:input id="question" type="text" class="input-inline" />

I think we should add the aria-labelledby attribute since the label control doesn't automatically apply the text for accessibility.
Attachment #9095427 - Flags: review?(alessandro) → review+
Attachment #9095427 - Attachment is obsolete: true
Attachment #9096536 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8bafe0778749
Use HTML input instead of XUL textbox in chat/content. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.