156302 - Unable to use DBCS for print-to-file file name

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Kasumi]

tested on 2002-07-02-07-1.0
Linux RedHat 7.1 JA

1. Launch Navigator
2. Select File/Print
3. Select Printer region/Print to/File
4. Click Coose File button then type file name having DBCS then
   click Save button
   You will see the corrupted file name or balnk file name for .ps 
   file

Comment 1

[rods (gone)]

I am using our own file dialog for this, and I will need some L10N help with this...

Comment 2

[Kasumi]

What can I do for you ?

Comment 3

[Roland Mainz]

rods:
I "guess" that we do not convert the unicode filename string to the
users/machines current locale/encoding...

Comment 4

[Roland Mainz]

Reporter:
Which encoding does your japanese linux use (e.g. PCK, UTF-8) ?

AFAIK we convert the file name from UCS2 to UTF-8 in some places instead of UTF2
to the platform's encoding...

Comment 5

[Roland Mainz]

correction:
s/UTF2/UCS2/

Comment 6

[rods (gone)]

Roland, where are we do the UTF-8 conversions? Is it in the printing code or in
other file dialog code?

Comment 7

[Kasumi]

charset is EUC-JP. This is default.

Comment 8

[Roland Mainz]

rods wrote:
> Roland, where are we do the UTF-8 conversions? Is it in the printing code or 
> in other file dialog code?

In printing code, shattered over the whole gfx/ code. The problem is that we
don't have a simple NS_ConvertUCS2toFilesystemEncoding() (or similar) ...
somewhere I found that NS_ConvertUCS2toUTF8() was used and I followed the
example (which means all *.UTF-8 locales will work, but now locales like
ja_JP.PCK).

I can take the bug when someone tells me which macro I should use instead...

Comment 9

[Roland Mainz]

darin:
We can't use |NS_CopyUnicodeToNative| from
http://lxr.mozilla.org/seamonkey/source/xpcom/io/nsNativeCharsetUtils.h , right
?

Comment 10

[Darin Fisher]

NS_CopyUnicodeToNative is currently only implemented for XP_UNIX.  I've been
meaning to complete its implementation (not hard).  See bug 166612.  One thing
about nsNativeCharsetUtils: it should only be used on file paths.

for the time being, i would recommend using nsIFile/nsILocalFile to do your
charset conversions.  sounds crufty, and it is, but it will do the trick.  once
NS_CopyUnicodeToNative is implemented, you'll be able to simplify your code. 
add some XXX comments, file a bug and mark it dependent on bug 166612 ;-)

Comment 11

[Roland Mainz]

Darin Fisher wrote:
> NS_CopyUnicodeToNative is currently only implemented for XP_UNIX. 

The code we're talking about is Unix/Linux-only... :)

> I've been
> meaning to complete its implementation (not hard).  See bug 166612.  One thing
> about nsNativeCharsetUtils: it should only be used on file paths.
> for the time being, i would recommend using nsIFile/nsILocalFile to do your
> charset conversions.  sounds crufty, and it is, but it will do the trick.  
> once NS_CopyUnicodeToNative is implemented, you'll be able to simplify your 
> code. 
> add some XXX comments, file a bug and mark it dependent on bug 166612 ;-)

nsIFile/nsILocalFile cannot be used in this case (or we'll endup in rewriting
much code) since we are feeding pathnames to some APIs which want file _names_.

Since this issue is Unix/Linux-only I'd like to use NS_CopyUnicodeToNative()
(which is implemented on these platformss). Is that OK for you ?

Comment 12

[Darin Fisher]

in that case, using NS_CopyNativeToUnicode and NS_CopyUnicodeToNative should be
fine.

Comment 13

[Roland Mainz]

Darin Fisher wrote:
> in that case, using NS_CopyNativeToUnicode and NS_CopyUnicodeToNative 
> should be fine.

Thanks!

----

rods:
Should I take this one ?

Comment 14

[rods (gone)]

Yes, please do.

Comment 15

[Roland Mainz]

Taking per comment #14 ...

Comment 16

[Roland Mainz]

[e-mail]:
Can you check whether printing to file in a *.UTF8 locale (like ja_JP.UTF-8
etc.) works correctly ?

Comment 17

[Kasumi]

tested on 2002-09-30-06-1.0
locale = ja-JP.utf8

Doesn't work. A file having ascii as file name can't save in a folder having
DBCS as folder name either.

Comment 18

[Roland Mainz]

Kasumi wrote:
> tested on 2002-09-30-06-1.0

Can you test it with "trunk", please ?

> locale = ja-JP.utf8

On which OS are you working on ?

> Doesn't work.

Weired. Are you sure that you've only used a file name with no path in front of
it ?

> A file having ascii as file name can't save in a folder having
> DBCS as folder name either.

OK, maybe we have two independant problems here... the conversion and maybe a
problem that |fopen()| doesn't like the input...

Comment 19

[Roland Mainz]

Accepting bug...

Comment 20

[Roland Mainz]

xpcom/io/nsNativeCharsetUtils.h isn't exported yet (bug 166612 ("implement
NS_CopyNativeToUnicode / NS_CopyUnicodeToNative on all platforms") will fix
that...) ...

Comment 21

[Roland Mainz]

Attachment: Hacked(!!) prototype patch for 2002-09-29-08-trunk

5min hack patch for testing

ToDo:
- Bug 166612 ("implement NS_CopyNativeToUnicode / NS_CopyUnicodeToNative on all
platforms) needs to be fixed to get |NS_CopyNativeToUnicode()| and
|NS_CopyUnicodeToNative()| exported
- Bug 171809 ("RFE: Create |NS_ConvertUnicodeToNative| and
|NS_ConvertNativeToUnicode|") needs to be implemented to get rid of the hacked
versions in this patch
- Xlib toolkit needs to be patched
- PostScript and Xprint modules should use the unicode<-->native functions
where required, too

Comment 22

[Roland Mainz]

Kasumi:
Can you test the patch if it fixes your problem (using both *.UTF-8 locale+UTF-8
filenames and the the same procedure with DBCS), please ?

Comment 23

[Kasumi]

Roland:
Could you show me how to integrate this patch to test?

Comment 24

[Roland Mainz]

Kasumi wrote:
> Could you show me how to integrate this patch to test?

Do you build yourself on Unix/Linux ?

If the answer is "yes" then you can simply apply the patch to your tree like
this:
1. Verify that the patch applies cleanly to the tree:
% gpatch -p0 --dry-run <attachment_cgi_id_101197_action_view
2. If [1] was successfull then remove the "--dry-run" switch and do the gpatch
again
3. Build the Zilla as usual
4. Test it

Comment 25

[Kasumi]

Unfortunately my answer is "No".
How about in the case of "No"?

Comment 26

[Roland Mainz]

Kasumi wrote:
> Unfortunately my answer is "No".
> How about in the case of "No"?

Well, I could make a build for you, but only for Solaris/SPARC (or the older
SuSE Linux 6.4/x86 - but I have no clue if such an old Linux build works with
DBCS) ...

Comment 27

[Roland Mainz]

Does anyone else here have a DBCS-enabled Linux and can help testing the patch
(or knows someone who can help or knows someone who knows someone who can help ?
:) ?

Comment 28

[Yuying Long]

cc Brian and Shanjian who may can help.

Comment 29

[kill this account]

For printing issues would you kindly also cc: in the Sun developers:

[e-mail] and [e-mail] 

Comment 30

[Kenneth Herron]

The patch for bug 193001 should have rendered this moot. Gecko now uses the GTK printing system for print dialogs. If this is an issue with the GTK dialog, please open a new bug.