1563026 - Add a right-click context menu item for the one-off search buttons to set as default for private browsing

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

As part of adding a separate private browsing search engine, we want to add a context menu option on the one-off search buttons to be able to set it as default.

Comment 1

[Mark Banner (:standard8)]

Note: enable/disable display per the pref added in bug 1562922.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1563026 - Migrate search one-offs xul fragment to use fluent.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1563026 - Add a right-click context menu item for the one-off search buttons to set as default for private browsing.

Depends on D47078

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9095172 [details]
Bug 1563026 - Add a right-click context menu item for the one-off search buttons to set as default for private browsing.

Hi Michael, please can you check the new string for this patch please (and functionality if you want!) - you can see the extra menu option if you right-click on one of the one-off search buttons in either the address bar or the search bar.

Note that the browser.search.separatePrivateDefault.enabled preference needs to be true for you to be able to see it.

Builds available here:

Mac: https://queue.taskcluster.net/v1/task/fgbUtTICTROkt7n6rf99Mw/runs/0/artifacts/public/build/target.dmg
Windows: https://queue.taskcluster.net/v1/task/C4V16yGiTBa8CftkP5TpHA/runs/0/artifacts/public/build/target.zip

(these also have the preferences UI patch).

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 9095172 [details]
Bug 1563026 - Add a right-click context menu item for the one-off search buttons to set as default for private browsing.

Dropping ui-review request as the string may change.

Having talked with L10n, we're ok with landing the strings and having minor churn, as there's not many of them for this feature.

Comment 6

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2feba8cfa37229c5f5a92538786d944e701b0a3b

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a3b3e463261
Migrate search one-offs xul fragment to use fluent. r=fluent-reviewers,mak,flod
https://hg.mozilla.org/integration/autoland/rev/b124b26983e4
Add a right-click context menu item for the one-off search buttons to set as default for private browsing. r=fluent-reviewers,mak,flod

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1a3b3e463261
https://hg.mozilla.org/mozilla-central/rev/b124b26983e4