Closed Bug 1563026 Opened 5 months ago Closed 2 months ago

Add a right-click context menu item for the one-off search buttons to set as default for private browsing

Categories

(Firefox :: Search, task, P2)

task
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.3 - Sept 30 - Oct 13
Tracking Status
firefox71 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

As part of adding a separate private browsing search engine, we want to add a context menu option on the one-off search buttons to be able to set it as default.

Note: enable/disable display per the pref added in bug 1562922.

Depends on: 1583147
Assignee: nobody → standard8
Status: NEW → ASSIGNED

Comment on attachment 9095172 [details]
Bug 1563026 - Add a right-click context menu item for the one-off search buttons to set as default for private browsing.

Hi Michael, please can you check the new string for this patch please (and functionality if you want!) - you can see the extra menu option if you right-click on one of the one-off search buttons in either the address bar or the search bar.

Note that the browser.search.separatePrivateDefault.enabled preference needs to be true for you to be able to see it.

Builds available here:

Mac: https://queue.taskcluster.net/v1/task/fgbUtTICTROkt7n6rf99Mw/runs/0/artifacts/public/build/target.dmg
Windows: https://queue.taskcluster.net/v1/task/C4V16yGiTBa8CftkP5TpHA/runs/0/artifacts/public/build/target.zip

(these also have the preferences UI patch).

Attachment #9095172 - Flags: ui-review?(mverdi)

Comment on attachment 9095172 [details]
Bug 1563026 - Add a right-click context menu item for the one-off search buttons to set as default for private browsing.

Dropping ui-review request as the string may change.

Having talked with L10n, we're ok with landing the strings and having minor churn, as there's not many of them for this feature.

Attachment #9095172 - Flags: ui-review?(mverdi)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a3b3e463261
Migrate search one-offs xul fragment to use fluent. r=fluent-reviewers,mak,flod
https://hg.mozilla.org/integration/autoland/rev/b124b26983e4
Add a right-click context menu item for the one-off search buttons to set as default for private browsing. r=fluent-reviewers,mak,flod
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Iteration: --- → 71.3 - Sept 30 - Oct 13
Regressions: 1588416
Flags: qe-verify+
QA Contact: pablo.muir
You need to log in before you can comment on or make changes to this bug.