Allow artifact builds to work with ESR and Release trees
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox-esr60 fixed, firefox-esr68 fixed, firefox67 wontfix, firefox68 fixed, firefox69 fixed)
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file)
Right now, trying to push to Try with --artifact from a release or ESR tree causes a failure due to beta/inbound/central being the only allowed trees. This recently slowed down the backport of a security fix to ESR60 under time pressure. Is there a reason we can't add m-r/m-esr60/m-esr68 to the list of candidate trees?
|
||
Comment 1•5 years ago
|
||
Looking at the code that uses the list of candidate trees here, it looks like the work it does is at least somewhat expensive. So I can see an argument for not wanting to add too many trees to the list. That said, there definitely wouldn't be a problem adding those trees to the list on those branches.
And actually, it looks like it queries each tree to see if the revision is in that tree, and only then does an more expensive lookup for that tree, so it might not be unreasonable to just add m-r to the list. It might make more sense to just add m-esr* just to the relevant branches, though.
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by rvandermeulen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96727b48dc3d Add more trees to the candidate tree list for artifact builds. r=tomprince
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
| uplift | ||
https://hg.mozilla.org/releases/mozilla-release/rev/72267a36f91c141b8be274d195f88de6354dc6f6
https://hg.mozilla.org/releases/mozilla-esr68/rev/1380f8064c63c262f87811b5501f94356268db9f
https://hg.mozilla.org/releases/mozilla-esr60/rev/5e6e39f648858604b0112656420df1926c45ee01
Description
•