Closed Bug 1563038 Opened 1 year ago Closed 1 year ago

Allow artifact builds to work with ESR and Release trees

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(firefox-esr60 fixed, firefox-esr68 fixed, firefox67 wontfix, firefox68 fixed, firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr60 --- fixed
firefox-esr68 --- fixed
firefox67 --- wontfix
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

Right now, trying to push to Try with --artifact from a release or ESR tree causes a failure due to beta/inbound/central being the only allowed trees. This recently slowed down the backport of a security fix to ESR60 under time pressure. Is there a reason we can't add m-r/m-esr60/m-esr68 to the list of candidate trees?

Looking at the code that uses the list of candidate trees here, it looks like the work it does is at least somewhat expensive. So I can see an argument for not wanting to add too many trees to the list. That said, there definitely wouldn't be a problem adding those trees to the list on those branches.

And actually, it looks like it queries each tree to see if the revision is in that tree, and only then does an more expensive lookup for that tree, so it might not be unreasonable to just add m-r to the list. It might make more sense to just add m-esr* just to the relevant branches, though.

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96727b48dc3d
Add more trees to the candidate tree list for artifact builds. r=tomprince
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.