1563062 - Remove unused bits of old about:addons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task)

Description

[Andrew Swan [:aswan]]

We still have some non-trivial blockers before we can do bug 1558982, but in the mean time there's a bunch of dead code (including a bunch of xbl bindings) that can be removed.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1563062 Part 1: Remove tests of old about:addons

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1563062 Part 2: Remove unused bits of old about:addons

Comment 3

[Andrew Swan [:aswan]]

This looks pretty green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=64d7da3f1cc5b46c212b8b1ccaf5485db3665a4d

This shouldn't land during the freeze but it would be nice to have the reviews done before then so its ready to go.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46ad01c26df8
Part 1: Remove tests of old about:addons r=rpl
https://hg.mozilla.org/integration/autoland/rev/59255dd51e9a
Part 2: Remove unused bits of old about:addons r=mstriemer

Comment 5

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1563062) for Browser-chrome failure in toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255572557&repo=autoland&lineNumber=66026

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=255572557&revision=59255dd51e9abbdb7d8239cac317a43efe53b495

Backout:
https://hg.mozilla.org/integration/autoland/rev/2786509371657776451adaf95de7139962318102

Comment 6

[Andrew Swan [:aswan]]

New try run with mostly-green bc:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a38feffabeed2c0cc42e8e59d198a784d7a5498e

and with the browser_history_navigation debug failure fixed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d13f3c3a164ef83a3774c92622b73dafb028b3c

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f03444317763
Part 1: Remove tests of old about:addons r=rpl
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fb365554065
Part 2: Remove unused bits of old about:addons r=mstriemer

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f03444317763
https://hg.mozilla.org/mozilla-central/rev/4fb365554065

Comment 9

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, could you please provide steps to reproduce in order to correctly test this or otherwise set the "qe-verify-" flag. Thanks!