Closed Bug 1563077 Opened 5 years ago Closed 5 years ago

Calendar mozmill tests should use teardownModule, not teardownTest

Categories

(Calendar :: General, task)

Lightning 68
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 69.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

I don't know why the tests all use teardownTest, but I guess it's a case of copy-paste.

teardownModule happens after all tests in that file have run, whereas teardownTest happens after each test, which is wrong in at least one case where we have multiple tests.

Attached patch 1563077-teardown-module-1.diff — — Splinter Review

This is just a find/replace job. Rubber stamp, please.

Attachment #9075536 - Flags: review?(acelists)
Attachment #9075536 - Flags: review?(acelists) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/679e2f55f7fc
Change Calendar mozmill tests to use teardownModule, not teardownTest; r=aceman DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 7.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: