1563083 - Use HTML input instead of XUL textbox in EdAdvancedEdit.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

https://searchfox.org/comm-central/rev/94d2c771f935e9402ca3d19a43fafeeaa8f0ac4f/editor/ui/dialogs/content/EdAdvancedEdit.xul#87

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1563083_convert-textbox-input-EdAdvancedEdit-1.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9096852 [details] [diff] [review]
Bug-1563083_convert-textbox-input-EdAdvancedEdit-1.patch

Review of attachment 9096852 [details] [diff] [review]:
-----------------------------------------------------------------

Should add globalOverlay.js and editMenuOverlay.js

::: mail/components/compose/content/dialogs/EdAdvancedEdit.xul
@@ +15,5 @@
>  
>  <dialog xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml"
> +       id="advancedEditDlg"
> +       style="width: 40em;"
> +       title="&WindowTitle.label;"

looks like indented one space too little?

@@ +84,3 @@
>              <deck id="AddHTMLAttributeValueDeck" selectedIndex="0">
> +              <hbox flex="1" class="input-container">
> +                <html:input id="AddHTMLAttributeValueTextbox" class="input-inline"

please add type="text" (after id) for these

@@ +122,5 @@
>          <hbox>
>            <vbox flex="1">
> +            <label id="AddCSSAttributeNameLabel" value="&PropertyName.label;"/>
> +            <html:input id="AddCSSAttributeNameInput" class="input-inline"
> +                        flex="1" onchange="onInputCSSAttributeName();"

remove flex

@@ +128,5 @@
>            </vbox>
>            <vbox flex="1">
> +            <label id="AddCSSAttributeValueLabel" value="&AttValue.label;"/>
> +            <html:input id="AddCSSAttributeValueInput" class="input-inline"
> +                        flex="1" onchange="onChangeCSSAttribute();"

remove flex

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1563083_convert-textbox-input-EdAdvancedEdit.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9097119 [details] [diff] [review]
Bug-1563083_convert-textbox-input-EdAdvancedEdit.patch

Review of attachment 9097119 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d598510c6289
replace <textbox> in EdAdvancedEdit.xul. r=mkmelin