Closed Bug 1563083 Opened 1 year ago Closed 5 months ago

Use HTML input instead of XUL textbox in EdAdvancedEdit.xul

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: aleca, Assigned: khushil324, Mentored)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → khushil324
Attachment #9096852 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9096852 [details] [diff] [review]
Bug-1563083_convert-textbox-input-EdAdvancedEdit-1.patch

Review of attachment 9096852 [details] [diff] [review]:
-----------------------------------------------------------------

Should add globalOverlay.js and editMenuOverlay.js

::: mail/components/compose/content/dialogs/EdAdvancedEdit.xul
@@ +15,5 @@
>  
>  <dialog xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml"
> +       id="advancedEditDlg"
> +       style="width: 40em;"
> +       title="&WindowTitle.label;"

looks like indented one space too little?

@@ +84,3 @@
>              <deck id="AddHTMLAttributeValueDeck" selectedIndex="0">
> +              <hbox flex="1" class="input-container">
> +                <html:input id="AddHTMLAttributeValueTextbox" class="input-inline"

please add type="text" (after id) for these

@@ +122,5 @@
>          <hbox>
>            <vbox flex="1">
> +            <label id="AddCSSAttributeNameLabel" value="&PropertyName.label;"/>
> +            <html:input id="AddCSSAttributeNameInput" class="input-inline"
> +                        flex="1" onchange="onInputCSSAttributeName();"

remove flex

@@ +128,5 @@
>            </vbox>
>            <vbox flex="1">
> +            <label id="AddCSSAttributeValueLabel" value="&AttValue.label;"/>
> +            <html:input id="AddCSSAttributeValueInput" class="input-inline"
> +                        flex="1" onchange="onChangeCSSAttribute();"

remove flex
Attachment #9096852 - Flags: review?(mkmelin+mozilla) → review-
Attachment #9096852 - Attachment is obsolete: true
Attachment #9097119 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9097119 [details] [diff] [review]
Bug-1563083_convert-textbox-input-EdAdvancedEdit.patch

Review of attachment 9097119 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9097119 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d598510c6289
replace <textbox> in EdAdvancedEdit.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.