Closed
Bug 1563086
Opened 5 years ago
Closed 5 years ago
Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/*Color*, EdConvertToTable.xul, EdDictionary.xul
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: aleca, Assigned: aleca)
References
Details
Attachments
(1 file, 1 obsolete file)
11.16 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
- EdColorPicker.xul
- EdColorProps.xul
- EdConvertToTable.xul
- EdDictionary.xul
Updated•5 years ago
|
Summary: Use HTML input instead of XUL textbox in editor/ui/dialogs/content → Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/
Updated•5 years ago
|
Summary: Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/ → Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/*Color*, EdConvertToTable.xul, EdDictionary.xul
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → alessandro
Mentor: alessandro
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #9096794 -
Flags: review?(mkmelin+mozilla)
Comment 2•5 years ago
|
||
Comment on attachment 9096794 [details] [diff] [review] 1563086-textbox-html-input.patch Review of attachment 9096794 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/compose/content/dialogs/EdColorProps.xul @@ +113,5 @@ > </tooltip> > + <html:input id="BackgroundImageInput" > + type="text" > + class="uri-element input-inline" > + oninput="ChangeBackgroundImage()" this should really be onchange I think... but we can leave it for later ::: mail/components/compose/content/dialogs/EdConvertToTable.xul @@ +12,5 @@ > > <dialog title="&windowTitle.label;" > + xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" > + xmlns:html="http://www.w3.org/1999/xhtml" > + onload = "Startup()" please remove the spaces around =
Attachment #9096794 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 3•5 years ago
|
||
Spacing fixed and onchange method update.
Attachment #9096794 -
Attachment is obsolete: true
Attachment #9096954 -
Flags: review+
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Wow, Z3 crashes entirely.
I'll take a look to see what's going on.
Updated•5 years ago
|
Keywords: checkin-needed
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9ec6769e2139
replace <textbox> in EdColor{Picker|Props}.xul, EdConvertToTable.xul, EdDictionary.xul. r=mkmelin
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
You need to log in
before you can comment on or make changes to this bug.
Description
•