1563086 - Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/*Color*, EdConvertToTable.xul, EdDictionary.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

• EdColorPicker.xul
• EdColorProps.xul
• EdConvertToTable.xul
• EdDictionary.xul

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1563086-textbox-html-input.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9096794 [details] [diff] [review]
1563086-textbox-html-input.patch

Review of attachment 9096794 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/dialogs/EdColorProps.xul
@@ +113,5 @@
>    </tooltip>
> +  <html:input id="BackgroundImageInput"
> +              type="text"
> +              class="uri-element input-inline"
> +              oninput="ChangeBackgroundImage()"

this should really be onchange I think... but we can leave it for later

::: mail/components/compose/content/dialogs/EdConvertToTable.xul
@@ +12,5 @@
>  
>  <dialog title="&windowTitle.label;"
> +        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
> +        xmlns:html="http://www.w3.org/1999/xhtml"
> +        onload = "Startup()"

please remove the spaces around =

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: 1563086-textbox-html-input.patch

Spacing fixed and onchange method update.

Comment 4

[Alessandro Castellani [:aleca]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=3d6957e0a4833f1aec42d5a78a85305cc76ec31b

Comment 5

[Alessandro Castellani [:aleca]]

Wow, Z3 crashes entirely.
I'll take a look to see what's going on.

Comment 6

[Jorg K (CEST = GMT+2)]

Most likely nothing. I've rerun it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9ec6769e2139
replace <textbox> in EdColor{Picker|Props}.xul, EdConvertToTable.xul, EdDictionary.xul. r=mkmelin