Closed Bug 1563089 Opened 5 years ago Closed 5 years ago

Use HTML input instead of XUL textbox in EdHLineProps.xul

Categories

(Thunderbird :: General, task)

Product:
Thunderbird
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 71.0

People

(Reporter: aleca, Assigned: khushil324, Mentored)

References

Details

Attachments

(2 files, 3 obsolete files)

hr.png
21.45 KB, image/png
Details
Bug-1563089_textbox-to-input-EdHLineProps.patch
4.06 KB, patch
khushil324
: review+
Details | Diff | Splinter Review
  • EdFieldSetProps.xul
  • EdFormProps.xul
  • EdHLineProps.xul

EdFieldSetProps.xul and EdFormProps.xul not used by TB any more. These are the Props.xul files:
EdColorProps.xul EdImageProps.xul EdListProps.xul EdTableProps.xul EdHLineProps.xul EdLinkProps.xul EdNamedAnchorProps.xul
There are also individual bugs for some of them: bug 1563112, bug 1563106, bug 1563104, bug 1563105, bug 1563086.

Summary: Use HTML input instead of XUL textbox in editor/ui/dialogs/content/*props* → Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/*props*
Assignee: nobody → khushil324
Summary: Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/*props* → Use HTML input instead of XUL textbox in EdHLineProps.xul
Attachment #9096878 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9096878 [details] [diff] [review]
Bug-1563089_textbox-to-input-EdHLineProps.patch

Review of attachment 9096878 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin with the below fixed

::: mail/components/compose/content/dialogs/EdHLineProps.xul
@@ +47,5 @@
>          </hbox>
>        </vbox>
>        <vbox>
> +        <html:input class="narrow input-inline" id="width" onchange="forceInteger('width')"
> +                    aria-labelledby="widthLabel"/>

these should be type="number", and then you can remove the onchang=forceInteger
also please move id first
Attachment #9096878 - Flags: review?(mkmelin+mozilla) → review+

Heads up that this is missing the JS files to enable the right click:

<script src="chrome://global/content/globalOverlay.js"/>
<script src="chrome://global/content/editMenuOverlay.js"/>

We love right-clicks, can't do without them ;-)

Attachment #9096878 - Attachment is obsolete: true
Attachment #9097105 - Flags: review?(mkmelin+mozilla)
Attached image hr.png —

Seems to be some alignment issue

Attachment #9097105 - Attachment is obsolete: true
Attachment #9097105 - Flags: review?(mkmelin+mozilla)
Attachment #9097574 - Flags: review?(mkmelin+mozilla)
Attachment #9097574 - Attachment is obsolete: true
Attachment #9097574 - Flags: review?(mkmelin+mozilla)
Attachment #9097578 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9097574 [details] [diff] [review]
Bug-1563089_textbox-to-input-EdHLineProps.patch

Review of attachment 9097574 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Attachment #9097574 - Attachment is obsolete: false
Attachment #9097578 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9097574 - Attachment is obsolete: true

I have changed the commit message only.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b55b050060f5
replace <textbox> in EdHLineProps.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: