Closed Bug 1563097 Opened 1 year ago Closed 5 months ago

Use HTML input instead of XUL textbox in EdInsertTOC.xul

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: aleca, Assigned: khushil324, Mentored)

References

Details

Attachments

(1 file, 2 obsolete files)

  • EdInsertTable.xul
  • EdInsertTOC.xul
Summary: Use HTML input instead of XUL textbox in editor/ui/dialogs/content/**insert** → Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/**insert**
Assignee: nobody → khushil324

EdInsertTOC.xul is remaining now. I will work on that.

Also the other one: mail/components/compose/content/dialogs/EdInsertTable.xul

I have worked on it during the de-grid task and converted textbox to html:input there.
https://searchfox.org/comm-central/source/mail/components/compose/content/dialogs/EdInsertTable.xul

Sorry, my mistake, I did look inside.

Summary: Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/**insert** → Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/EdInsertTOC.xul
Attachment #9096853 - Flags: review?(mkmelin+mozilla)
Attachment #9096853 - Attachment is obsolete: true
Attachment #9096853 - Flags: review?(mkmelin+mozilla)
Attachment #9096854 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Summary: Use HTML input instead of XUL textbox in mail/components/compose/content/dialogs/EdInsertTOC.xul → Use HTML input instead of XUL textbox in EdInsertTOC.xul
Comment on attachment 9096854 [details] [diff] [review]
Bug-1563097_convert-textbox-input-EdInsertTOC-2.patch

Review of attachment 9096854 [details] [diff] [review]:
-----------------------------------------------------------------

Should add globalOverlay.js and editMenuOverlay.js

::: mail/components/compose/content/dialogs/EdInsertTOC.xul
@@ +63,4 @@
>              </menulist>
>            </html:td>
>            <html:td>
> +            <html:input id="header1Class" size="10"

please add type="text" for these

and class="input-inline"?
Attachment #9096854 - Flags: review?(mkmelin+mozilla)
Attachment #9096854 - Attachment is obsolete: true
Attachment #9097110 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9097110 [details] [diff] [review]
Bug-1563097_convert-textbox-input-EdInsertTOC.patch

Review of attachment 9097110 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin
Attachment #9097110 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/acb56daaa8fb
replace <textbox> in EdInsertTOC.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.