1563104 - Use HTML input instead of XUL textbox in EdLinkProps.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

https://searchfox.org/comm-central/rev/94d2c771f935e9402ca3d19a43fafeeaa8f0ac4f/editor/ui/dialogs/content/EdLinkProps.xul#37

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1563106_convert-textbox-to-input-EdLinkProps.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9096893 [details] [diff] [review]
Bug-1563106_convert-textbox-to-input-EdLinkProps.patch

Review of attachment 9096893 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/dialogs/EdLinkProps.xul
@@ +34,5 @@
>          <label id="linkTextCaption" class="header"/>
>        </hbox>
>        <vbox>
> +        <label id="linkTextMessage" control="linkTextInput" aria-labelledby="linkTextMessage"/>
> +        <html:input id="linkTextInput" class="input-inline"/>

please add type="text"
aria-labelledby="linkTextMessage" should be on the input, not the label. 

Also, need to import the js files to get context menu

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1563106_convert-textbox-to-input-EdLinkProps.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9097098 [details] [diff] [review]
Bug-1563106_convert-textbox-to-input-EdLinkProps.patch

Review of attachment 9097098 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 5

[Jorg K (CEST = GMT+2)]

The patch name talks about anchors and the bug number is wrong in the commit messages. More attention to detail, please.

This (Saturday!) afternoon I had nine patches to land: So far, one caused test failures, one didn't apply and this one has the wrong bug number.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ce35be25c2f
replace <textbox> in EdLinkProps.xul. r=mkmelin