Closed Bug 1563104 Opened 8 months ago Closed 5 months ago

Use HTML input instead of XUL textbox in EdLinkProps.xul

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: aleca, Assigned: khushil324, Mentored)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → khushil324
Attachment #9096893 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9096893 [details] [diff] [review]
Bug-1563106_convert-textbox-to-input-EdLinkProps.patch

Review of attachment 9096893 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/dialogs/EdLinkProps.xul
@@ +34,5 @@
>          <label id="linkTextCaption" class="header"/>
>        </hbox>
>        <vbox>
> +        <label id="linkTextMessage" control="linkTextInput" aria-labelledby="linkTextMessage"/>
> +        <html:input id="linkTextInput" class="input-inline"/>

please add type="text"
aria-labelledby="linkTextMessage" should be on the input, not the label. 

Also, need to import the js files to get context menu
Attachment #9096893 - Flags: review?(mkmelin+mozilla) → review-
Attachment #9096893 - Attachment is obsolete: true
Attachment #9097098 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9097098 [details] [diff] [review]
Bug-1563106_convert-textbox-to-input-EdLinkProps.patch

Review of attachment 9097098 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9097098 - Flags: review?(mkmelin+mozilla) → review+

The patch name talks about anchors and the bug number is wrong in the commit messages. More attention to detail, please.

This (Saturday!) afternoon I had nine patches to land: So far, one caused test failures, one didn't apply and this one has the wrong bug number.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1ce35be25c2f
replace <textbox> in EdLinkProps.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.