Closed Bug 1563106 Opened 8 months ago Closed 5 months ago

Use HTML input instead of XUL textbox in EdNamedAnchorProps.xul

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: aleca, Assigned: khushil324, Mentored)

References

Details

Attachments

(1 file, 2 obsolete files)

Assignee: nobody → khushil324
Attachment #9096885 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9096885 [details] [diff] [review]
Bug-1563106_textbox-to-input-EdNamedAnchorProps.patch

Review of attachment 9096885 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/dialogs/EdNamedAnchorProps.xul
@@ +31,3 @@
>           value="&anchorNameEditField.label;"
>           accesskey="&anchorNameEditField.accessKey;"/>
> +  <html:input id="nameInput" class="MinWidth20em input-inline" oninput="ChangeName()"

please add type="text" (after id)
Attachment #9096885 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9096885 [details] [diff] [review]
Bug-1563106_textbox-to-input-EdNamedAnchorProps.patch

Review of attachment 9096885 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, this is also missing 
  <script src="chrome://global/content/globalOverlay.js"/>
  <script src="chrome://global/content/editMenuOverlay.js"/>

(In reply to Magnus Melin [:mkmelin] from comment #4)

Actually, this is also missing
<script src="chrome://global/content/globalOverlay.js"/>
<script src="chrome://global/content/editMenuOverlay.js"/>

Why and when should we add these files?

To all files with <html:input> or otherwise there is no context menu on the inputs

Okay Cool, I will update all other files with this and type="text" where needed.

Attachment #9096885 - Attachment is obsolete: true
Attachment #9097099 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9097099 [details] [diff] [review]
Bug-1563106_textbox-to-input-EdNamedAnchorProps.patch

Review of attachment 9097099 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/dialogs/EdNamedAnchorProps.xul
@@ +33,5 @@
>           value="&anchorNameEditField.label;"
>           accesskey="&anchorNameEditField.accessKey;"/>
> +  <html:input id="nameInput" type="text" class="MinWidth20em input-inline"
> +              onchange="ChangeName()"
> +              tooltiptext="&nameInput.tooltip;"

tooltiptext= should be title= instead in html
Attachment #9097099 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9097099 - Attachment is obsolete: true
Attachment #9097124 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fed51e9af389
replace <textbox> in EdNamedAnchorProps.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.