1563120 - Use HTML input instead of XUL textbox in abMailListDialog.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

https://searchfox.org/comm-central/rev/94d2c771f935e9402ca3d19a43fafeeaa8f0ac4f/mail/components/addrbook/content/abMailListDialog.xul

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1563120-textbox-html-input.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9092271 [details] [diff] [review]
1563120-textbox-html-input.patch

Review of attachment 9092271 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/addrbook/content/abMailListDialog.xul
@@ +44,5 @@
>      <hbox id="ListNameContainer" align="center">
>        <spacer flex="1"/>
>        <label control="ListName" value="&ListName.label;" accesskey="&ListName.accesskey;" class="CardEditLabel"/>
> +      <hbox class="CardEditWidth input-container">
> +        <html:input id="ListName" class="input-inline"/>

add type="text" perhaps?

@@ +51,5 @@
>      <hbox id="ListNickNameContainer" align="center">
>        <spacer flex="1"/>
>        <label control="ListNickName" value="&ListNickName.label;" accesskey="&ListNickName.accesskey;" class="CardEditLabel"/>
> +      <hbox class="CardEditWidth input-container">
> +        <html:input id="ListNickName" class="input-inline"/>

here too

@@ +58,5 @@
>      <hbox id="ListDescriptionContainer" align="center">
>        <spacer flex="1"/>
>        <label control="ListDescription" value="&ListDescription.label;" accesskey="&ListDescription.accesskey;" class="CardEditLabel"/>
> +      <hbox class="CardEditWidth input-container">
> +        <html:input id="ListDescription" class="input-inline"/>

and here?

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: 1563120-textbox-html-input.patch

The type="text" attribute doesn't affect anything for now and the only location where it's used for styling is the preferences tab.
But I agree that it's better to specify the type anyway.

Comment 4

[Alessandro Castellani [:aleca]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b09f4a1df905827827ecc5022445db4a8acecac0

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad18b404c16f
Use HTML input instead of XUL textbox in abMailListDialog.xul. r=mkmelin